[WTH-474] 페널티 유저 api 구현 - #98
Merged
Hidden character warning
The head ref may contain hidden characters: "fix/WTH-474-\ud398\ub110\ud2f0-\uc720\uc800-api-\uad6c\ud604"
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
hyxklee
reviewed
Aug 25, 2026
| private val penaltyReader: PenaltyReader, | ||
| private val clubMemberPolicy: ClubMemberPolicy, | ||
| ) { | ||
| @Transactional(readOnly = true) |
4 tasks
soo0711
reviewed
Aug 25, 2026
Comment on lines
+65
to
+75
| @GetMapping("/penalty-rule") | ||
| @Operation(summary = "현재 동아리 패널티 규정 조회") | ||
| fun getPenaltyRule( | ||
| @TsidParam | ||
| @TsidPathVariable clubId: Long, | ||
| @Parameter(hidden = true) @CurrentUser userId: Long, | ||
| ): CommonResponse<PenaltyRuleResponse> = | ||
| CommonResponse.success( | ||
| UserResponseCode.USER_PENALTY_RULE_FIND_SUCCESS, | ||
| getPenaltyRuleQueryService.getRule(clubId), | ||
| ) |
Collaborator
There was a problem hiding this comment.
userId도 파라미터로 넘겨서 사용자가 가입한 동아리인지를 확인하는(정책) 로직도 있어야 할 것 같아요!
Member
Author
There was a problem hiding this comment.
말씀해주신대로 userId를 서비스로 전달해서 ClubMemberPolicy를 통해서 활성 멤버 검증 로직 추가했슴니다!!
soo0711
approved these changes
Aug 25, 2026
Base automatically changed from
fix/WTH-468-백엔드-패널티-관리-UI-변경에-따른-수정사항-반영
to
dev
August 25, 2026 14:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Summary
유저 마이페이지에서 페널티 목록 및 규정을 조회할 수 있는 API를 구현합니다.
📝 Changes
What
GET /api/v4/clubs/{clubId}/my/penalties)GET /api/v4/clubs/{clubId}/my/penalty-rule)Why
페널티 관리 UI 변경에 따라 유저가 본인의 페널티 내역 및 규정을 마이페이지에서 확인할 수 있어야 합니다.
How
GetUserPenaltyQueryService: 유저의 페널티 목록을 기수 단위로 조회GetUserMyPageQueryService: 기존 stats 응답에 페널티 수 포함ClubMemberMyPageController: 페널티 목록/규정 엔드포인트 추가GetPenaltyRuleQueryService는 어드민 PR(WTH-468)에서 구현, 해당 PR에서 재사용📸 Screenshots / Logs
💡 Reviewer 참고사항
본 PR은 어드민 페널티 PR(#97)을 base로 하고 있습니다! WTH-468(#97)이 dev에 머지되면 base를 dev로 변경할 예정입니다!
✅ Checklist