-
Notifications
You must be signed in to change notification settings - Fork 0
[WTH-468] 백엔드 패널티 관리 UI 변경에 따른 수정사항 반영 #97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The head ref may contain hidden characters: "fix/WTH-468-\uBC31\uC5D4\uB4DC-\uD328\uB110\uD2F0-\uAD00\uB9AC-UI-\uBCC0\uACBD\uC5D0-\uB530\uB978-\uC218\uC815\uC0AC\uD56D-\uBC18\uC601"
Changes from all commits
28254b6
0578400
0dfaba9
7c4197c
ed02c86
93902c4
20eed0d
a98bd6b
5b9a55e
6db74d1
de66d54
975be9a
e8dd5df
1c440ab
ae62a8f
07cd52f
ca10ec7
d5741a1
ec0f03a
fc91a47
411fd63
ced4eae
3ecebba
b50a856
8616053
31e83cb
667ae03
fcc2f23
14f0b9c
d741941
0d7bb6d
a4068b6
d4336b7
a6f911c
09b9d5b
6120d53
af0716b
5473c04
976b590
8475eda
2505c42
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,23 @@ | ||
| package com.weeth.domain.penalty.application.dto.request | ||
|
|
||
| import com.weeth.domain.penalty.domain.enums.PenaltyType | ||
| import io.swagger.v3.oas.annotations.media.Schema | ||
| import jakarta.validation.constraints.NotBlank | ||
| import jakarta.validation.constraints.NotEmpty | ||
| import jakarta.validation.constraints.Positive | ||
| import jakarta.validation.constraints.Size | ||
|
|
||
| data class SavePenaltyRequest( | ||
| @field:Schema(description = "패널티 대상 사용자 ID", example = "1") | ||
| val userId: Long, | ||
| @field:Schema(description = "패널티 사유", example = "정기모임 무단 불참") | ||
| val penaltyDescription: String?, | ||
| @field:Schema(description = "페널티 대상 사용자 ID 목록", example = "[1, 2, 3]") | ||
| @field:NotEmpty | ||
| val userIds: List<Long>, | ||
| @field:Schema(description = "페널티 점수", example = "1") | ||
| @field:Positive | ||
| val score: Int = 1, | ||
| @field:Schema(description = "페널티 사유", example = "정기모임 무단 불참") | ||
| @field:NotBlank | ||
| @field:Size(max = 20) | ||
| val penaltyDescription: String, | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 사유가 디자인 스펙에는 몇 자인지 안 나타나있는 것 같네용 한 번 확인해서 반영해주세요!
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 피그마 코멘트로 한 번 여쭤보긴 했는데 일단 임의로 50자로 제한해두었습니닷 추후 스펙이 확정되면 수정하겠습니다!
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 디자인 상으로는 20자가 적합할 것 같다고 하셔서 20자로 수정해두었습니다! |
||
| @field:Schema(description = "페널티 타입 (기본값: PENALTY)", example = "PENALTY", allowableValues = ["PENALTY", "WARNING"]) | ||
| val penaltyType: PenaltyType = PenaltyType.PENALTY, | ||
| ) | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| package com.weeth.domain.penalty.application.dto.request | ||
|
|
||
| import io.swagger.v3.oas.annotations.media.Schema | ||
| import jakarta.validation.constraints.Size | ||
|
|
||
| data class SavePenaltyRuleRequest( | ||
| @field:Schema(description = "패널티 규정 내용 (null 또는 빈 값이면 삭제)", example = "정기 모임에 출석을 하지 않았을때 (=결석)", nullable = true) | ||
| @field:Size(max = 500) | ||
| val content: String?, | ||
| ) |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,16 @@ | ||
| package com.weeth.domain.penalty.application.dto.request | ||
|
|
||
| import io.swagger.v3.oas.annotations.media.Schema | ||
| import jakarta.validation.constraints.Positive | ||
| import jakarta.validation.constraints.Size | ||
|
|
||
| data class UpdatePenaltyRequest( | ||
| @field:Schema(description = "수정할 패널티 ID", example = "1") | ||
| @field:Schema(description = "수정할 페널티 ID", example = "1") | ||
| val penaltyId: Long, | ||
| @field:Schema(description = "수정할 패널티 사유", example = "정기모임 무단 불참 (수정)") | ||
| @field:Schema(description = "수정할 페널티 사유 (null=변경 안 함)", example = "정기모임 무단 불참 (수정)", nullable = true) | ||
| @field:Size(max = 20) | ||
| val penaltyDescription: String?, | ||
|
Comment on lines
+10
to
12
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @field:Size(max = 20) 수정할 때도 20 글자수 제한 들어가야할 것 가타요!
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 헙 그러네요... 꼼꼼한 리뷰 감사함니다,, 생각도 못하고 있었어요 |
||
| @field:Schema(description = "수정할 페널티 점수 (null=변경 안 함)", example = "2", nullable = true) | ||
| @field:Positive | ||
| val score: Int?, | ||
| ) | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| package com.weeth.domain.penalty.application.dto.response | ||
|
|
||
| import com.weeth.domain.club.domain.enums.MemberStatus | ||
| import io.swagger.v3.oas.annotations.media.Schema | ||
|
|
||
| data class MemberPenaltyDetailResponse( | ||
| @field:Schema(description = "프로필 이미지 URL", nullable = true) | ||
| val profileImageUrl: String?, | ||
| @field:Schema(description = "이름", example = "홍길동") | ||
| val name: String, | ||
| @field:Schema(description = "소속 기수 목록", example = "[6, 7]") | ||
| val cardinals: List<Int>, | ||
| @field:Schema(description = "멤버 상태", example = "ACTIVE") | ||
| val memberStatus: MemberStatus, | ||
| @field:Schema(description = "자기소개", nullable = true) | ||
| val bio: String?, | ||
| @field:Schema(description = "페널티 목록") | ||
| val penalties: List<PenaltyDetailResponse>, | ||
| ) |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| package com.weeth.domain.penalty.application.dto.response | ||
|
|
||
| import io.swagger.v3.oas.annotations.media.Schema | ||
|
|
||
| data class PenaltyRuleResponse( | ||
| @field:Schema(description = "패널티 규정 내용 (미설정 시 null)", nullable = true) | ||
| val content: String?, | ||
| ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DB 변경시 resources/db/migration에 마이그레이션 쿼리가 필요합니당
Flyway에 대해서 한 번 Claude와 함께 이야기해보고, 이해한 후에 추가해주세용
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아 확인했습니당
V12__add_club_warning_and_penalty_rule.sql로 파일 추가했습니다!