-
Notifications
You must be signed in to change notification settings - Fork 0
[fix] #203 - 재발급 원자성 처리 및 CHIPS 제거 #204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Jy000n
wants to merge
2
commits into
develop
Choose a base branch
from
fix/#203-reissue-remove-chips
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+27
−28
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[p2] 같은 refreshToken으로 재발급 요청이 동시에 들어오면, 먼저 처리된 요청만 성공하고 나머지는 기존 토큰이 이미 삭제되어 401을 반환하는 것으로 이해했습니다!
예를 들어 accessToken 만료 시 여러 API 요청이 각각 재발급을 시도하면, 하나는 성공하더라도 다른 요청의 재발급 실패를 보고 프론트가 로그아웃 처리할 가능성이 있을 것 같습니다.
현재 프론트에서는 재발급이 진행 중일 때 다른 요청들이 그 결과를 기다리도록 처리하고 있을까요? 해당 처리가 되어 있다면 이번 방식으로도 괜찮을 것 같습니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
맞습니다. 동시에 같은 refresh token으로 재발급 시도 시, 토큰 재사용을 막기 위해 하나만 성공 후 나머지는 401을 반환하게끔 하였습니다.
다만 이게 실제로 사용자한테 로그아웃으로 이어지는지는 프론트의 재발급 동시성 처리 방식에 달려있어서 이 부분은 프론트 측에 확인을 해봐야 알 것 같습니다. 확인 후 다시 답변 이어서 달도록 하겠습니다!!