Skip to content

[hotfix] #108 - 타이머 종료 불가 에러 해결 #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jy000n merged 1 commit into from
Jul 13, 2026
Merged

[hotfix] #108 - 타이머 종료 불가 에러 해결 #109

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/main/java/com/Timo/Timo/domain/timer/service/TimerService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,10 +181,12 @@ public void deleteTimersByTodo(Long todoId) {
timerRecordRepository.deleteByTodoId(todoId);
}

@Transactional(readOnly = false)
public TimerFinishResponse completeTimer(Long userId, Long timerId) {
return finishTimer(userId, timerId, TimerStatus.COMPLETED);
}

@Transactional(readOnly = false)
public TimerFinishResponse stopTimer(Long userId, Long timerId) {
Comment on lines +184 to 190

@coderabbitai coderabbitai Bot Jul 13, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🩺 Stability & Availability | 🟠 Major | 🏗️ Heavy lift

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

# Map and inspect the relevant service files
git ls-files 'src/main/java/com/Timo/Timo/domain/timer/service/*.java' \
  'src/main/java/com/Timo/Timo/domain/*/service/*.java' \
  'src/main/java/com/Timo/Timo/**/TransactionTemplate*.java' \
  'src/main/java/com/Timo/Timo/**/ai*.java' \
  'src/main/java/com/Timo/Timo/**/feedback*.java'

echo '--- TimerService outline ---'
ast-grep outline src/main/java/com/Timo/Timo/domain/timer/service/TimerService.java --view expanded

echo '--- TimerService relevant slice ---'
nl -ba src/main/java/com/Timo/Timo/domain/timer/service/TimerService.java | sed -n '1,320p'

echo '--- Search for generateAiFeedback and TransactionTemplate usage ---'
rg -n "generateAiFeedback|TransactionTemplate|new TransactionTemplate|setPropagationBehavior|PROPAGATION_|createFeedback|aiTodoService" src/main/java/com/Timo/Timo -S

Repository: Team-Timo/Timo-Server

Length of output: 3602

🏁 Script executed:

#!/bin/bash
set -euo pipefail

# Inspect the specific call chain and transaction boundaries
files=$(git ls-files 'src/main/java/com/Timo/Timo/domain/timer/service/*.java' \
  'src/main/java/com/Timo/Timo/domain/*/service/*.java' \
  'src/main/java/com/Timo/Timo/**/TransactionTemplate*.java' \
  'src/main/java/com/Timo/Timo/**/feedback*.java' \
  'src/main/java/com/Timo/Timo/**/ai*.java' \
  'src/main/java/com/Timo/Timo/**/service/*.java')

printf '%s\n' "$files"

echo '--- TimerService outline ---'
ast-grep outline src/main/java/com/Timo/Timo/domain/timer/service/TimerService.java --view expanded

echo '--- TimerService slice (160-280) ---'
nl -ba src/main/java/com/Timo/Timo/domain/timer/service/TimerService.java | sed -n '160,280p'

echo '--- TimerService full transaction helpers search ---'
rg -n "generateAiFeedback|finishTimerInTransaction|TransactionTemplate|setPropagationBehavior|PROPAGATION_|createFeedback|aiTodoService" src/main/java/com/Timo/Timo -S

Repository: Team-Timo/Timo-Server

Length of output: 3957

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo '--- TimerService 178-280 ---'
sed -n '178,280p' src/main/java/com/Timo/Timo/domain/timer/service/TimerService.java | cat -n

echo '--- AiTodoService ---'
sed -n '1,260p' src/main/java/com/Timo/Timo/domain/ai/service/AiTodoService.java | cat -n

echo '--- GeminiService ---'
sed -n '1,260p' src/main/java/com/Timo/Timo/domain/ai/service/GeminiService.java | cat -n

Repository: Team-Timo/Timo-Server

Length of output: 15399

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo '--- TransactionTemplate / propagation search ---'
rg -n "TransactionTemplate|setPropagationBehavior|PROPAGATION_|`@Transactional`" src/main/java/com/Timo/Timo/domain/ai src/main/java/com/Timo/Timo/domain/timer -S

echo '--- AI history service ---'
sed -n '1,260p' src/main/java/com/Timo/Timo/domain/ai/service/AiTodoHistoryService.java | cat -n

echo '--- AI request limiter ---'
sed -n '1,260p' src/main/java/com/Timo/Timo/domain/ai/service/AiRequestRateLimiter.java | cat -n

Repository: Team-Timo/Timo-Server

Length of output: 7865

AI 호출을 트랜잭션 밖으로 분리하세요.
TransactionTemplate의 기본 전파가 REQUIRED라서, 현재는 completeTimer/stopTimer의 트랜잭션 안에서 generateAiFeedback(...)와 updateAiFeedback(...)가 함께 실행됩니다. findByIdForUpdate로 잡은 락이 외부 Gemini 호출 동안 유지되어 동시성 지연과 타임아웃 위험이 큽니다. 종료 상태는 먼저 커밋하고, AI 피드백 생성/저장은 별도 트랜잭션이나 커밋 이후 훅으로 분리해 주세요.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/main/java/com/Timo/Timo/domain/timer/service/TimerService.java` around
lines 184 - 190, Update the completeTimer and stopTimer flow so the timer-ending
state is committed before generateAiFeedback and updateAiFeedback run. Configure
the AI feedback work to execute after the ending transaction in a separate
transaction or commit-after hook, ensuring the findByIdForUpdate lock is
released before any external Gemini call.

Source: Path instructions

return finishTimer(userId, timerId, TimerStatus.STOPPED);
}
Expand Down