Skip to content

assert finalized contracts reject all mutating entrypoints#670

Merged
mikewheeleer merged 2 commits into
Talenttrust:mainfrom
HademiData:test/contracts-finalized-lock-matrix
Jun 29, 2026
Merged

assert finalized contracts reject all mutating entrypoints#670
mikewheeleer merged 2 commits into
Talenttrust:mainfrom
HademiData:test/contracts-finalized-lock-matrix

Conversation

@HademiData

@HademiData HademiData commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Closes #571


Summary

Adds security tests verifying finalized escrow contracts remain immutable.

Changes

  • Added tests ensuring finalized contracts reject mutating operations.
  • Added test verifying a second finalization attempt returns AlreadyFinalized.
  • Added tests confirming read-only endpoints (get_contract and get_finalization_record) continue to work after finalization.
  • Enabled the new security test module in the test suite.

Validation

  • cargo fmt
  • cargo build
  • cargo test

@drips-wave

drips-wave Bot commented Jun 29, 2026

Copy link
Copy Markdown

@HademiData Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@mikewheeleer

Copy link
Copy Markdown
Contributor

great stuff — thanks for picking it up 🙌

@mikewheeleer mikewheeleer merged commit a219a6d into Talenttrust:main Jun 29, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add tests asserting finalized contracts reject deposit, release, refund, and cancel

2 participants