Skip to content

Add CYD-3248S035C Support#522

Open
NellowTCS wants to merge 3 commits intoTactilityProject:mainfrom
NellowTCS:cyd-3248s035c
Open

Add CYD-3248S035C Support#522
NellowTCS wants to merge 3 commits intoTactilityProject:mainfrom
NellowTCS:cyd-3248s035c

Conversation

@NellowTCS
Copy link
Copy Markdown
Contributor

@NellowTCS NellowTCS commented Apr 11, 2026

This pull request adds support for a new device, the CYD 3248S035C, to Tactility.

Summary by CodeRabbit

  • New Features

    • Added CYD 3248S035C device: ESP32 target with 3.5" rectangular display (320×480, 165 DPI), LVGL 16-bit color, backlight control, touch support, integrated SD card and device-tree-backed hardware description, plus module registration for the board.
  • Chores

    • CI updated to include automated firmware builds for the CYD 3248S035C board.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 11, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: be650c13-28e1-4451-b975-1b5cb5d8cc67

📥 Commits

Reviewing files that changed from the base of the PR and between deeecb6 and 59942be.

📒 Files selected for processing (1)
  • Devices/cyd-3248s035c/Source/devices/Display.h

📝 Walkthrough

Walkthrough

Adds support for the CYD 3248S035C board. Updates CI build matrix to include board id cyd-3248s035c (arch: esp32). Introduces Devices/cyd-3248s035c with CMakeLists, device module, hardware Configuration, display and SD card factories and headers, and module source. Adds device tree cyd,3248s035c.dts, device.properties, and devicetree.yaml. Targets ST7796 display, GT911 touch, PWM backlight, and SPI SD card.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Add CYD-3248S035C Support' directly and clearly summarizes the main objective of the changeset—adding support for a new device to the project.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3


ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: f9569e53-cba1-4405-8ee9-bdeea7271f5d

📥 Commits

Reviewing files that changed from the base of the PR and between e64f4ff and e92c008.

📒 Files selected for processing (11)
  • .github/workflows/build.yml
  • Devices/cyd-3248s035c/CMakeLists.txt
  • Devices/cyd-3248s035c/Source/Configuration.cpp
  • Devices/cyd-3248s035c/Source/devices/Display.cpp
  • Devices/cyd-3248s035c/Source/devices/Display.h
  • Devices/cyd-3248s035c/Source/devices/SdCard.cpp
  • Devices/cyd-3248s035c/Source/devices/SdCard.h
  • Devices/cyd-3248s035c/Source/module.cpp
  • Devices/cyd-3248s035c/cyd,3248s035c.dts
  • Devices/cyd-3248s035c/device.properties
  • Devices/cyd-3248s035c/devicetree.yaml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant