Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdds support for the CYD 3248S035C board. Updates CI build matrix to include board id cyd-3248s035c (arch: esp32). Introduces Devices/cyd-3248s035c with CMakeLists, device module, hardware Configuration, display and SD card factories and headers, and module source. Adds device tree cyd,3248s035c.dts, device.properties, and devicetree.yaml. Targets ST7796 display, GT911 touch, PWM backlight, and SPI SD card. 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 3
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: f9569e53-cba1-4405-8ee9-bdeea7271f5d
📒 Files selected for processing (11)
.github/workflows/build.ymlDevices/cyd-3248s035c/CMakeLists.txtDevices/cyd-3248s035c/Source/Configuration.cppDevices/cyd-3248s035c/Source/devices/Display.cppDevices/cyd-3248s035c/Source/devices/Display.hDevices/cyd-3248s035c/Source/devices/SdCard.cppDevices/cyd-3248s035c/Source/devices/SdCard.hDevices/cyd-3248s035c/Source/module.cppDevices/cyd-3248s035c/cyd,3248s035c.dtsDevices/cyd-3248s035c/device.propertiesDevices/cyd-3248s035c/devicetree.yaml
This pull request adds support for a new device, the CYD 3248S035C, to Tactility.
Summary by CodeRabbit
New Features
Chores