Conversation
…d for consistency with peer methods
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1034.
Summary
CloudKitSyncEnginehas six methods that touch the optionalcontainer/database. Five throwSyncError.accountUnavailablewhen the entitlement is absent; the sixth,currentAccountId, returnednilinstead. This PR makes it throw, matching its peers.The single caller (
SyncCoordinator.checkAccountStatusatTablePro/Core/Sync/SyncCoordinator.swift:632) already wraps the call intry?, so the observable behavior is unchanged. The fix is a contract-tightening only.The matching test in
TableProTests/Core/Sync/CloudKitSyncEngineTests.swiftflips fromcurrentAccountIdReturnsNiltocurrentAccountIdThrows, mirroring the other five test cases.CHANGELOG
No entry: this tightens an internal contract on a feature still in
[Unreleased](added by #1028, not yet released).Test plan
swiftlint lint --strictclean (no Swift body changes touch lint rules)xcodebuild ... test -only-testing:TableProTests/CloudKitSyncEngineTestspasses (skips when host is iCloud-entitled)