Repository navigation
Conversation
…admin-map-regions
…admin-map-regions
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…admin-map-regions
…admin-map-regions
…admin-map-regions
…admin-map-regions
# Conflicts: # build.gradle # docs/map/location-jobs.md # docs/map/map-contract-v1.md # src/main/java/org/sopt/hashi/admin/dto/CreateRestaurantRequest.java # src/main/java/org/sopt/hashi/admin/dto/UpdateRestaurantRequest.java # src/main/java/org/sopt/hashi/restaurant/domain/Restaurant.java # src/main/java/org/sopt/hashi/restaurant/service/RestaurantService.java # src/test/java/org/sopt/hashi/admin/service/AdminRestaurantServiceTest.java # src/test/java/org/sopt/hashi/admin/web/AdminRestaurantControllerTest.java # src/test/java/org/sopt/hashi/restaurant/domain/RestaurantLocationTest.java # src/test/java/org/sopt/hashi/restaurant/internal/map/google/MapGoogleLiveFlowTest.java # src/test/java/org/sopt/hashi/restaurant/service/LocationJobMySqlTest.java # src/test/java/org/sopt/hashi/restaurant/service/MapQueryLoadTest.java
# Conflicts: # src/main/java/org/sopt/hashi/restaurant/RestaurantPort.java # src/main/java/org/sopt/hashi/restaurant/code/RestaurantErrorCode.java # src/main/java/org/sopt/hashi/restaurant/service/RestaurantPortImpl.java # src/test/java/org/sopt/hashi/restaurant/service/CollectionMapPortMySqlIntegrationTest.java # src/test/java/org/sopt/hashi/restaurant/service/RestaurantServiceIntegrationTest.java
…admin-map-regions
…admin-map-regions
…admin-map-regions # Conflicts: # src/main/java/org/sopt/hashi/restaurant/RestaurantPort.java # src/main/java/org/sopt/hashi/restaurant/service/RestaurantPortImpl.java
…admin-map-regions
gichanGim
approved these changes
Oct 10, 2026
| @Schema(description = "현재 페이지의 지역 설정. 비활성 초안도 포함") List<AdminMapRegionResponse> content, | ||
| @Schema(description = "0부터 시작하는 현재 페이지", example = "0") int page, | ||
| @Schema(description = "요청한 페이지 크기", example = "20") int size, | ||
| @Schema(description = "활성·비활성 지역 전체 개수", example = "3") long totalElements, |
Member
There was a problem hiding this comment.
다른 response에서 전체 개수에 대한 필드 명을 totalCount로 통일하고 있어서, 여기도 마찬가지로 동일하게 맞춰주시면 좋을 것 같습니다!
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔥 작업 내용 (What)
관리자가 관광 지역을 등록하고 식당의 소속 지역을 지정하는 API를 추가했습니다. 예를 들어 긴자 선택 시 보여 줄 지도 중심·범위와 긴자에 포함할 식당을 관리합니다.
🧩 변경 사항 (Details)
기존 ADMIN 권한과
admin → RestaurantPort → restaurant구조를 사용합니다. 새로운 테이블이나 라이브러리 없이 선행 지도 모델에 관리 기능을 연결합니다.요청 예시와 입력 순서는
docs/map/admin-regions.md에도 정리했습니다. 통합 테스트는 선행 PR의 지도 전용 Redis 연결 설정을 사용하도록 맞췄습니다.📸 스크린샷
없음
🔗 관련 이슈
Closes #251
✅ 체크리스트