Conversation
ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Free Run ID: 📒 Files selected for processing (4)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthrough사용자 로그아웃 API를 추가했습니다. Origin과 리프레시 쿠키를 검증하고, 사용자 리프레시 세션을 폐기한 뒤 쿠키를 만료시킵니다. 액세스 JWT는 블랙리스트에 등록하지 않습니다. Changes사용자 로그아웃
Estimated code review effort: 2 (Simple) | ~10 minutes Sequence Diagram(s)sequenceDiagram
participant Client
participant AuthController
participant UserAuthService
participant RefreshTokenSession
Client->>AuthController: POST /api/v1/auth/logout
AuthController->>AuthController: Origin 및 리프레시 쿠키 검증
AuthController->>UserAuthService: 리프레시 토큰 폐기 요청
UserAuthService->>RefreshTokenSession: 사용자 리프레시 세션 폐기
AuthController-->>Client: 쿠키 만료 및 LOGOUT_SUCCESS 응답
Note 🎁 Summarized by CodeRabbit FreeYour organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Essentials by visiting https://app.coderabbit.ai/settings/billing. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔥 작업 내용 (What)
이번 PR에서 어떤 작업을 했는지 간단히 설명해주세요.
사용자 로그아웃 API를 구현하였습니다.
기존 어드민 로그아웃에 적용한 로직을 그대로 적용하였습니다.
🧩 변경 사항 (Details)
구체적인 변경 사항을 나열해주세요.
AuthController:/logout엔드포인트 추가. Origin 검증 → 리프레시 쿠키 추출 → 폐기 → 쿠키 만료 (어드민 로그아웃과 동일 패턴)UserAuthService.logout: 리프레시 타입·ROLE_USER만 수용,RefreshTokenStore.revoke로 세션 삭제AuthSuccessCode.LOGOUT_SUCCESS(AUTH-205) 추가docs/conventions/auth.md: "사용자 로그아웃 MVP 제외" 문구를 실제 구현 내용으로 갱신📸 스크린샷
API 응답 / Swagger / 에러 화면 등이 있다면 첨부해주세요.
리뷰어가 꼭 알아야 할 사항이 있다면 적어주세요.
🔗 관련 이슈
관련된 이슈가 있다면 연결해주세요.
Closes #178
✅ 체크리스트
Summary by CodeRabbit
새 기능
문서