Skip to content

[FEAT/#106] 자동 로그인 구현 #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sohee6989 merged 1 commit into from
Jan 19, 2026
Merged

[FEAT/#106] 자동 로그인 구현 #107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/src/main/java/com/cherrish/android/presentation/main/MainScreen.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ fun MainScreen(
) {
splashNavGraph(
navigateToOnboarding = appState::navigateToOnboarding,
navigateToHome = appState::navigateToHome,
paddingValues = innerPadding
)

Expand Down
20 changes: 18 additions & 2 deletions app/src/main/java/com/cherrish/android/presentation/splash/SplashScreen.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,18 +20,34 @@ import androidx.compose.ui.res.painterResource
import androidx.compose.ui.res.vectorResource
import androidx.compose.ui.tooling.preview.Preview
import androidx.compose.ui.unit.dp
import androidx.hilt.navigation.compose.hiltViewModel
import com.cherrish.android.R
import com.cherrish.android.core.common.extension.collectLatestSideEffect
import com.cherrish.android.core.designsystem.theme.CherrishTheme
import kotlinx.coroutines.delay

@Composable
fun SplashRoute(
navigateToOnboarding: () -> Unit,
paddingValues: PaddingValues
navigateToHome: () -> Unit,
paddingValues: PaddingValues,
viewModel: SplashViewModel = hiltViewModel()
) {
LaunchedEffect(Unit) {
viewModel.isAutoLoginCheck()
}

viewModel.sideEffect.collectLatestSideEffect { sideEffect ->
delay(3000)
navigateToOnboarding()

when (sideEffect) {
SplashSideEffect.NavigateToOnboarding -> {
navigateToOnboarding()
}
SplashSideEffect.NavigateToHome -> {
navigateToHome()
}
}
}

SplashScreen(
Expand Down
6 changes: 6 additions & 0 deletions app/src/main/java/com/cherrish/android/presentation/splash/SplashSideEffect.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
package com.cherrish.android.presentation.splash

sealed interface SplashSideEffect {
data object NavigateToOnboarding : SplashSideEffect
data object NavigateToHome : SplashSideEffect
}
32 changes: 32 additions & 0 deletions app/src/main/java/com/cherrish/android/presentation/splash/SplashViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
package com.cherrish.android.presentation.splash

import androidx.lifecycle.ViewModel
import androidx.lifecycle.viewModelScope
import com.cherrish.android.core.local.TokenManager
import dagger.hilt.android.lifecycle.HiltViewModel
import javax.inject.Inject
import kotlinx.coroutines.flow.MutableSharedFlow
import kotlinx.coroutines.flow.SharedFlow
import kotlinx.coroutines.flow.asSharedFlow
import kotlinx.coroutines.launch

@HiltViewModel
class SplashViewModel @Inject constructor(
private val tokenManager: TokenManager
) : ViewModel() {
private val _sideEffect = MutableSharedFlow<SplashSideEffect>()
val sideEffect: SharedFlow<SplashSideEffect> = _sideEffect.asSharedFlow()
Comment on lines +17 to +18

@coderabbitai coderabbitai Bot Jan 19, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🏁 Script executed:

find . -name "SplashViewModel.kt" -type f

Repository: TEAM-Cherrish/Cherrish-Android

Length of output: 153

🏁 Script executed:

rg -l "collectLatestSideEffect" --type=kt

Repository: TEAM-Cherrish/Cherrish-Android

Length of output: 100

🏁 Script executed:

cat -n ./app/src/main/java/com/cherrish/android/presentation/splash/SplashViewModel.kt

Repository: TEAM-Cherrish/Cherrish-Android

Length of output: 1341

🏁 Script executed:

rg -n "collectLatestSideEffect" --type-list | grep -i kotlin

Repository: TEAM-Cherrish/Cherrish-Android

Length of output: 463

🏁 Script executed:

rg -nA 10 "collectLatestSideEffect"

Repository: TEAM-Cherrish/Cherrish-Android

Length of output: 12322

🏁 Script executed:

rg -n "isAutoLoginCheck"

Repository: TEAM-Cherrish/Cherrish-Android

Length of output: 298

🏁 Script executed:

cat -n ./app/src/main/java/com/cherrish/android/presentation/splash/SplashScreen.kt

Repository: TEAM-Cherrish/Cherrish-Android

Length of output: 4026

SharedFlow에 replay = 1을 설정하세요.

isAutoLoginCheck()가 LaunchedEffect 내에서 비동기로 실행되고, collectLatestSideEffect도 독립적인 LaunchedEffect를 생성하기 때문에 emit이 collect 준비 전에 발생할 수 있습니다. 기본값 replay = 0에서는 이 이벤트가 손실되어 사용자가 화면에 고착될 수 있습니다.

수정 사항 
-    private val _sideEffect = MutableSharedFlow<SplashSideEffect>()
+    private val _sideEffect = MutableSharedFlow<SplashSideEffect>(replay = 1)
🤖 Prompt for AI Agents 
In
`@app/src/main/java/com/cherrish/android/presentation/splash/SplashViewModel.kt`
around lines 17 - 18, The current _sideEffect =
MutableSharedFlow<SplashSideEffect>() uses the default replay=0 which can drop
events emitted before collectors (from isAutoLoginCheck() /
collectLatestSideEffect launched in separate LaunchedEffect scopes) are ready;
change the MutableSharedFlow instantiation to
MutableSharedFlow<SplashSideEffect>(replay = 1) so the last side-effect is
buffered and delivered to late collectors while leaving sideEffect:
SharedFlow<SplashSideEffect> = _sideEffect.asSharedFlow() unchanged.


fun isAutoLoginCheck() {
viewModelScope.launch {
val id = tokenManager.getId()
_sideEffect.emit(
if (id != null) {
SplashSideEffect.NavigateToHome
} else {
SplashSideEffect.NavigateToOnboarding
}
)
}
}
}
2 changes: 2 additions & 0 deletions app/src/main/java/com/cherrish/android/presentation/splash/navigation/SplashNavigation.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,13 @@ fun NavController.navigateToSplash(navOptions: NavOptions? = null) {

fun NavGraphBuilder.splashNavGraph(
navigateToOnboarding: () -> Unit,
navigateToHome: () -> Unit,
paddingValues: PaddingValues
) {
composable<Splash> {
SplashRoute(
navigateToOnboarding = navigateToOnboarding,
navigateToHome = navigateToHome,
paddingValues = paddingValues
)
}
Expand Down