Repository navigation
Refactor AppSettings dialogs and simplify state management - #366
Merged
Merged
Conversation
This change removes dedicated state classes for the app settings, shortcut, and template dialogs, replacing them with local state management within the composables. It also refactors how app settings are added by passing the `AppSetting` model directly through the ViewModel and Use Case. - Removed `AppSettingDialogState`, `ShortcutDialogState`, and `TemplateDialogState`. - Moved dialog components to the `com.android.geto.feature.appsettings.dialog` package and refactored them to use `remember` and `mutableStateOf` for UI state. - Updated `AppSettingsViewModel` and `AddAppSettingUseCase` to accept the `AppSetting` domain model instead of individual field parameters. - Simplified `AppSettingsScreen` by replacing state holder objects with simple boolean flags for dialog visibility. - Refactored dialog interaction logic to use standard callback patterns for better separation of concerns.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change removes dedicated state classes for the app settings, shortcut, and template dialogs, replacing them with local state management within the composables. It also refactors how app settings are added by passing the
AppSettingmodel directly through the ViewModel and Use Case.AppSettingDialogState,ShortcutDialogState, andTemplateDialogState.com.android.geto.feature.appsettings.dialogpackage and refactored them to userememberandmutableStateOffor UI state.AppSettingsViewModelandAddAppSettingUseCaseto accept theAppSettingdomain model instead of individual field parameters.AppSettingsScreenby replacing state holder objects with simple boolean flags for dialog visibility.