[BootstrapAdminUI] Expose as ux bundle #362
Conversation
|
@Jibbarth This is very interesting, will you be able to finish this great work? |
|
Hello @loic425, PR updated 😊 Let me know if you have any question |
Jibbarth
force-pushed
the
feature/asset-mapper
branch
from
7e61e94 to
b2715ab
Compare
| import { Controller } from '@hotwired/stimulus'; | ||
| import ApexCharts from 'apexcharts'; | ||
|
|
||
| export default class extends Controller { |
There was a problem hiding this comment.
could be lazy, as used only on dashboard page
| @@ -0,0 +1,4 @@ | |||
|
|
|||
There was a problem hiding this comment.
remove empty line, or indicate this is for "demo" purpose (how to extend entrypoint)
| @@ -1 +1,2 @@ | |||
| import './scripts/statistics_chart.js'; | |||
| // App entrypoint - Leave empty unless need to override entrypoint from BootstrapAdminUi | |||
There was a problem hiding this comment.
🤔 maybe remove this file, or use it instead admin_entry
| @@ -0,0 +1,2 @@ | |||
|
|
|||
| "Sylius\\UiTranslations\\": "src/UiTranslations/src/" | ||
| } | ||
| }, | ||
| "autoload": {}, |
There was a problem hiding this comment.
todo: double check if we can keep the autoload here. I think it'll be simplier for IDE integration
| "@popperjs/core": "^2.9.2", | ||
| "@tabler/core": "^1.4.0", | ||
| "@tabler/core/dist/css/tabler.min.css": "^1.4.0", | ||
| "apexcharts": "^4.4.0", |
There was a problem hiding this comment.
Is this used by the bundle, or only by the app around ? I guess it could be drop 🤔
There was a problem hiding this comment.
It could be good to introduce a tool to check those dependencies, I asked Copilot and it seems to be able to do so and tell us what is realy used or not.
It can be introduced in another PR.
3 participants
Hello 👋
This is a draft/Poc to expose the BootstrapAdminUi as an Ux bundle, to let the app using asset-mapper/importmap importing dependencies.
It helps me to review symfony/symfony-docs#21292
It could fix #200. I tested to add a custom controller in assets/controllers and referencing it inside a template works well directly.
The scss to css move has been made by an AI, and it kinda work, except for the dark theme. But the toggler works :)
The benefits of this solution is that we do no longer have to build assets for bootstrap-admin-ui and version them in the public folder. It will be the final app that build things.
Let me know if there is any interests on this, to continue works.
We could at the end have a assetmapper config, beside to a webpack-encore config for users who prefer it.