Repository navigation
[BUG] Allow contracts to be parsed when ghost function is forward declared - #6
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes inconsistent function contract storage/retrieval across redeclarations by always keying ASTContext::FunctionContracts entries off a function’s canonical declaration.
Changes:
- Store function contract info under
FD->getCanonicalDecl()ingetOrCreateFunctionContract. - Lookup function contract info using
FD->getCanonicalDecl()ingetFunctionContract.
SwayamInSync
added a commit
that referenced
this pull request
Jul 27, 2026
[BUG] Allow contracts to be parsed when ghost function is forward declared
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates how function contracts are accessed and stored in the
ASTContextto ensure consistency when dealing with redeclared functions. The main change is that function contract information is now always associated with a function's canonical declaration, preventing issues with multiple redeclarations.Improvements to Function Contract Handling:
getOrCreateFunctionContractandgetFunctionContractinASTContextto use the canonical declaration of aFunctionDeclas the key in theFunctionContractsmap, ensuring consistent storage and retrieval for redeclared functions.