Fix/party invitation ci test mutation#385
Merged
Cedarich merged 3 commits intoJun 8, 2026
Merged
Conversation
- POST /escrows/:id/parties/:partyId/accept — sets status to ACCEPTED, records respondedAt, logs PARTY_ACCEPTED event, notifies escrow creator - POST /escrows/:id/parties/:partyId/reject — sets status to REJECTED, auto-cancels escrow when a required party (buyer/seller) rejects, notifies escrow creator - GET /escrows/pending-invitations — lists escrows with PENDING party invitations for the authenticated user - fund() now gates on all buyer+seller parties having ACCEPTED status - PARTY_INVITED notification dispatched for each invited party on escrow creation - Add PARTY_INVITED, PARTY_ACCEPTED, PARTY_REJECTED to NotificationEventType enum - Add email templates for new notification events - Add respondedAt column to Party entity + migration - Import NotificationsModule into EscrowModule - Unit tests for accept, reject, getPendingInvitations, and fund gate Closes StayLitCodes#274
[Backend] Complete Party Invitation and Acceptance Flow
… mutation Tests in acceptPartyInvitation and rejectPartyInvitation describe blocks shared a single mutable party object across test cases. The service mutates party.status in-place, causing subsequent tests to receive an already-mutated object and throw unexpected BadRequestException errors. Fix by spreading a fresh copy with explicit status: PartyStatus.PENDING on each partyRepository.findOne mock call. Also applies prettier formatting across backend source files. Closes StayLitCodes#274
Cedarich
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Workflow fix