fix(render): make the manifest's complete flag mean something - #141
Open
ringoliRob wants to merge 1 commit into
Open
fix(render): make the manifest's complete flag mean something#141ringoliRob wants to merge 1 commit into
complete flag mean something#141ringoliRob wants to merge 1 commit into
Conversation
`complete` was written as a literal `True` on every capture, so nothing in tiles.json could ever distinguish a full page from one viewport of it. The signal that would have revealed the difference — a measured page height equal to the emulated viewport (i.e. the tile height) — was neither warned about at render time nor recorded in a form a later consumer could check, since the tile height itself never made it into URL manifests. This is independent of any particular truncation bug: the same silence held for the height formula StarTrail-org#131 fixed and will hold for whatever causes the next one. - `page_metrics.truncation_reason()` states the rule once, next to the shared measurement JS, so the standard and turbo backends agree on what a manifest means whichever Chrome the capture ran on. - Both backends log a warning and write `complete: false` when the probe fell back or the height came back at exactly one viewport. The tiles are still captured and written — only the claim about them changes. - URL manifests now record `tile_height` and `viewport_width`, so a consumer can redo the comparison instead of being told the geometry out of band. - The standard path now treats a zero/negative measured height as a probe failure, matching the turbo path; it used to tile nothing and report success. - pixelbrowse's SKILL.md reads tiles.json instead of guessing: the "do not run `ls`, just read tile_0000.jpg" rule made a truncated capture indistinguishable from a short page, and a failed render indistinguishable from an empty one. Note for the index pipeline: `complete: false` makes the embed stage skip a tile directory, so an affected page is now dropped from an index build rather than indexed as a fraction of itself.
|
@ringoliRob is attempting to deploy a commit to the andylizf's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
completewas written as a literalTrueon every capture, so nothing in tiles.json could ever distinguish a full page from one viewport of it. The signal that would have revealed the difference — a measured page height equal to the emulated viewport (i.e. the tile height) — was neither warned about at render time nor recorded in a form a later consumer could check, since the tile height itself never made it into URL manifests.This is independent of any particular truncation bug: the same silence held for the height formula #131 fixed and will hold for whatever causes the next one.
page_metrics.truncation_reason()states the rule once, next to the shared measurement JS, so the standard and turbo backends agree on what a manifest means whichever Chrome the capture ran on.complete: falsewhen the probe fell back or the height came back at exactly one viewport. The tiles are still captured and written — only the claim about them changes.tile_heightandviewport_width, so a consumer can redo the comparison instead of being told the geometry out of band.ls, just read tile_0000.jpg" rule made a truncated capture indistinguishable from a short page, and a failed render indistinguishable from an empty one.Note for the index pipeline:
complete: falsemakes the embed stage skip a tile directory, so an affected page is now dropped from an index build rather than indexed as a fraction of itself.