Skip to content

fix(security): resolve chrome sandbox escapes and prompt injections - #138

Open
Youcef3939 wants to merge 1 commit into
StarTrail-org:mainfrom
Youcef3939:security/sandbox-hardening
Open

fix(security): resolve chrome sandbox escapes and prompt injections#138
Youcef3939 wants to merge 1 commit into
StarTrail-org:mainfrom
Youcef3939:security/sandbox-hardening

Conversation

@Youcef3939

Copy link
Copy Markdown

this pull request refactors how chrome sandboxing arguments are handled throughout the codebase. instead of unconditionally passing --no-sandbox, a new centralized function determines when sandboxing should be disabled, improving security and flexibility. additionally, documentation has been updated for clarity and safety

sandbox argument handling

  • introduced a new sandbox_args() function in chrome.py that returns Chrome sandbox arguments, only adding --no-sandbox if running as root on Linux or if the PIXELSHOT_NO_SANDBOX environment variable is set. It also logs a warning when running as root
  • refactored all chrome launch code (cdp.py, fast_cdp.py, cdp_overlap.py, cdp_pipelined_dc.py, cdp_pipelined_tabs.py, connection.py, render_ondemand.py, and screenshot.py) to use sandbox_args() instead of hardcoding --no-sandbox. [1] [2] [3] [4] [5] [6] [7] [8]

documentation and safety

  • updated documentation in SKILL.md and screenshot.md to clarify usage, add safety warnings about untrusted screenshot payloads, and improve cropping instructions with a more robust pillow script. [1] [2] [3]

code organization

  • added necessary imports for sandbox_args in all relevant modules for consistency and maintainability. [1] [2] [3] [4] [5] [6] [7] [8]

also part of the issue #135

@vercel

vercel Bot commented Aug 5, 2026

Copy link
Copy Markdown

@Youcef3939 is attempting to deploy a commit to the andylizf's projects Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant