Repository navigation
feat(tabs): add Tabs molecule - #292
Merged
Merged
Conversation
ludevdot
reviewed
Jul 2, 2026
ludevdot
left a comment
Collaborator
There was a problem hiding this comment.
Review notes for the Tabs ARIA relationship when inactive panels are destroyed.
Collaborator
|
Only remaining cleanup: please update the PR description to mention the included |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #34
Tabsmolecule with controlled/uncontrolled selection, APG tab semantics, roving focus, manual/automatic activation, disabled states, semantic colors, placements, and link-like tab support.Tabsfrom the package root.Review scope
src/components/molecules/tabs/*src/index.ts.gitignoreandpnpm-lock.yamlworkspace changes were not included in this branch commit.lottie-webeval build warning is unrelated to Tabs.Type of change
Workflow gates
Closes #NNNor maintainer approved an exception.status:approvedbefore implementation starts.In progress, branch/worktree recorded.<type>(<optional scope>): <description>..playwright-mcp,page-*.png,page-*.jpeg,*.md.playwright-output.Component evidence (required for component changes)
types.ts,use*.ts,Component.tsx,Component.test.tsx,Component.stories.tsx,index.ts.types.ts; JSX component has no state, CVA calls, or business logic.@defaultJSDoc intypes.ts(node scripts/verify-prop-default-docs.mjs).theme.css; no hardcoded colors or arbitrary color utilities.Accessibility evidence
Validation evidence
pnpm exec tsc --noEmit— passedpnpm exec vitest run src/components/molecules/tabs/Tabs.test.tsx— 27 tests passedpnpm exec vitest run src/storybook-explicit-examples.test.ts— passedpnpm run test— 37 files / 796 tests passedpnpm run build— passedpnpm run verify:package— passed for React 18 and React 19 consumerslottie-webeval warning remains unrelated to this PRScreenshots or recordings
Not attached. Storybook stories were smoke-checked locally; reviewers can inspect
Molecules/Tabsstories directly.Notes for reviewer
role="tab"semantics. R4 resilience review noted this does not provide native link context-menu affordances; accepted as a follow-up tradeoff for this component API.variant,color,size,radius,placement, oractivationMode.Colorsuses explicit examples instead of.map()to satisfy the repo's story explicitness test.