feat: add event emitter#675
Merged
Merged
Conversation
avoids need for transferring ownership after deployment
xenide
reviewed
Apr 27, 2026
Contributor
Author
|
Discussed in person: |
xenide
reviewed
Apr 27, 2026
swap Ownable => AccessControlEnumerable on deployment we make both relevant addresses admins and restrict contract access to this role
Contributor
Author
|
@Will-Smith11 I've opted to modify the access control pattern of this contract -- on deployment we make both relevant addresses admins and restrict function access to this role. This should be sufficient to allow relevant addresses to emit events both on queuing and on executing fee claims |
Will-Smith11
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an exceedingly simple periphery contract which allows the owner to call it in order to emit events.
Currently this contract implements 3 methods:
emitFeeClaimQueued,emitFeeClaimExecuted, andemitGenericEvent.We had previously discussed only the 2nd one of these; the others are included for completeness and future flexibility -- using
emitFeeClaimQueuedwhen queuing a fee claim could help with observability (it perhaps can help an observer decode and understand what is being queued), andemitGenericEventprovides the ability to add new events in the future without needing to migrate to a different contract (although because the contract code will not contain the event definition, the events may be challenging to decode / the topic0 will not be automatically processed e.g. by Etherscan).Let me know if we are confident we will not use
emitFeeClaimQueuedand/oremitGenericEventand I will remove them.Otherwise, I could see potentially wanting the
FeeClaimQueued/FeeClaimExecutedevents to have their data styled a bit closer to what will be used for the actual fee claim call -- let me know if there are any changes desired here.