chore: remove outdated todo#608
Merged
Merged
Conversation
estensen
commented
Aug 25, 2025
| /// chosen command. | ||
| #[inline] | ||
| pub fn run() -> eyre::Result<()> { | ||
| // TODO: This should also contain rollup args. |
Collaborator
Author
There was a problem hiding this comment.
CombinedArgs contains rollup args
angstrom/crates/cli/src/op_angstrom.rs
Lines 34 to 39 in c43a5f2
estensen
commented
Aug 25, 2025
| - This trait is a template for the most important chain-related primitives used in Angstrom: `Block`, `BlockHeader`, `BlockBody`, `SignedTx`, `Receipt` | ||
| - The default implementation is always [`EthPrimitives`](https://reth.rs/docs/reth/primitives/struct.EthPrimitives.html) | ||
| - If needed, can be overridden to use [`OpPrimitives`](https://reth.rs/docs/op_reth/primitives/struct.OpPrimitives.html) | ||
| TODO: Add which crates are affected by this |
Collaborator
Author
There was a problem hiding this comment.
I don't think adding it here provides much value. IMO the PR #569 will provide sufficient context.
mempirate
approved these changes
Aug 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.