SLVS-2764 Start collecting request level exceptions #6578

eray-felek-sonarsource · 2026-01-06T10:48:02Z

No description provided.

georgii-borovinskikh-sonarsource · 2026-01-06T15:57:55Z

src/SLCore/ISLCoreInstanceHandler.cs

        {
            logger.WriteLine(SLCoreStrings.SLCoreHandler_StartingInstance);
            await currentInstanceHandle.InitializeAsync();
+            monitoringService.Init();


This will re-initialize on every SLCore restart (if it crashed, for example). Do we still want that or do we only want to initialize once?

Telemetry is re-initialized every time SLCORE crashes, I think it it a good practice the keep the same behavior also we rely on telemetry to decide if we initialize monitoring

src/Integration/Telemetry/MonitoringService.cs

georgii-borovinskikh-sonarsource · 2026-01-06T16:04:16Z

src/SLCore/Core/IJsonRpc.cs

+
+    protected override JsonRpcError.ErrorDetail CreateErrorDetails(JsonRpcRequest request, Exception exception)
+    {
+        monitoringService.ReportException(exception, $"JsonRpcWrapper.CreateErrorDetails:{request.Method ?? "unknown"}");


I need to check if there's anything useful in those exceptions. Unfortunately, from the top of my head, it always says "Internal error" and not much more

This is one example: https://sonar-x0.sentry.io/issues/7167581220/?project=4510622904877056&query=is%3Aunresolved&referrer=issue-stream
We at least get the request causing the exception. We discussed and did the same capturing for IntelliJ, I think it's a good start.

I'm not familiar with the .NET implementation, but there is normally a way to get the SLCORE stack trace that led to the 'internal error'. There is probably a certain type of exception, in which you can access those details, by running in debug mode you might be able to find that.
The 2nd thing is that reporting all exceptions from this method might be too much. I think we could try to focus only on exceptions that are uncaught by SLCORE and translate to 'internal errors'.

They have InternalError = -32603, defined, I guess we could only report these as a start then

Also added error data information

src/Integration/Telemetry/MonitoringService.cs

src/Integration.UnitTests/Telemetry/MonitoringServiceTests.cs

georgii-borovinskikh-sonarsource

A few more comments + please test this on an old VS on the VM that we have

georgii-borovinskikh-sonarsource

Some things to fix with synchronization, otherwise looks good. Please only merge once those are fixed

src/Integration/Telemetry/ISentrySdk.cs

src/Integration/Telemetry/MonitoringService.cs

damien-urruty-sonarsource · 2026-01-07T14:07:59Z

src/Integration/Telemetry/MonitoringService.cs

+    {
+        try
+        {
+            sentrySdk.Init(options =>


Did you find a way to turn off automatic collection of uncaught exceptions?

We have a separate ticket for this

I will start working on it after I merge this to feature branch. We decided to merge to feature since that ticket is implemented to avoid noise

damien-urruty-sonarsource · 2026-01-07T14:12:42Z

src/Integration/Telemetry/MonitoringService.cs

+    {
+        try
+        {
+            sentrySdk.Init(options =>


We will probably need a way to uniquely identify users on the VS side too

As discussed we can start implementing this after the unhandled exception task is finished

src/SLCore/Core/IJsonRpc.cs

georgii-borovinskikh-sonarsource · 2026-01-09T08:47:37Z

src/Integration/Telemetry/MonitoringService.cs


+    private static void TryAddCommonErrorData(Sentry.Scope scope, Exception exception)
+    {
+        if (exception is not LocalRpcException localRpcException)


Why only local exceptions? Do we rely on SLCore to capture other exceptions?

Yes we also have a exception catching mechanism on SLCORE, currently only for intellij, but I will also include other IDEs as well

sonarqubecloud · 2026-01-09T09:00:49Z

SonarQube reviewer guide

Important

We are currently testing different models for AI Summary.
Please give us your feedback by filling this form.

Model A:

Summary: Adds Sentry SDK integration and monitoring service for error reporting with telemetry opt-in/out support.

Review Focus: The monitoring service initialization and error reporting flow, particularly the integration with JsonRpcWrapper's CreateErrorDetails method which reports internal/invalid parameter errors to Sentry. Verify exception handling doesn't interfere with normal operation and that telemetry status correctly controls Sentry activation.

Start review at: src/Integration/Telemetry/MonitoringService.cs. This is the core implementation that manages the Sentry lifecycle and exception reporting logic.

Model B:

Summary: Add Sentry error monitoring integration with telemetry-aware exception reporting to enable crash tracking based on user telemetry preferences.

Review Focus:

The MonitoringService initialization logic that queries telemetry status and conditionally enables Sentry
How exceptions are captured and enriched with RPC error context in JsonRpcWrapper
The integration points where monitoring is initialized/reinitialized based on telemetry opt-in/out
Thread safety with the state lock in MonitoringService and proper error swallowing for unsupported VS versions

Start review at: src/Integration/Telemetry/MonitoringService.cs. This is the core service managing Sentry initialization and exception reporting. Understanding its lifecycle (Init/Reinit/Close) and the telemetry-aware behavior is essential for validating the overall monitoring strategy.

See all code changes, issues, and quality metrics in one place.

Quality Gate passed

Issues
0 New issues
4 Accepted issues
0 Dependency risks

Measures
0 Security Hotspots
90.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

georgii-borovinskikh-sonarsource · 2026-01-09T09:07:44Z

src/SLCore/Core/IJsonRpc.cs


-        if (errorDetail.Code == JsonRpcErrorCode.InternalError)
+        if (errorDetail.Code == JsonRpcErrorCode.InternalError ||
+            errorDetail.Code == JsonRpcErrorCode.InvalidParams)


well, this one was just an example, there are other types. there are also other exception types such as https://learn.microsoft.com/en-us/dotnet/api/streamjsonrpc.remoterpcexception?view=streamjsonrpc-2.21

It's a bit unclear to me why we only choose some of them and not all

We would like to limit the exceptions to ones that we are interested to look first. InternalError was one thing we wanted to tackle first. It doesn't mean we will not look at the others, when we spend enough time and tackle these we might actually disable internal errors and tackle other exceptions. The purpose is to have focus during such investigations

eray-felek-sonarsource force-pushed the feature/ef/SLVS-2764-start-collecting-reqest-level-exceptions branch 5 times, most recently from 6082677 to 27be1b5 Compare January 6, 2026 12:37

eray-felek-sonarsource changed the title ~~SLVS-2764 tart collecting reqest level exceptions~~ SLVS-2764 Start collecting reqest level exceptions Jan 6, 2026

eray-felek-sonarsource requested review from damien-urruty-sonarsource and vnaskos-sonar January 6, 2026 13:36

eray-felek-sonarsource changed the title ~~SLVS-2764 Start collecting reqest level exceptions~~ SLVS-2764 Start collecting request level exceptions Jan 6, 2026

eray-felek-sonarsource force-pushed the feature/ef/SLVS-2764-start-collecting-reqest-level-exceptions branch from 56a0b3a to 28c247f Compare January 6, 2026 15:15

vnaskos-sonar requested review from georgii-borovinskikh-sonarsource and removed request for vnaskos-sonar January 6, 2026 15:42

georgii-borovinskikh-sonarsource reviewed Jan 6, 2026

View reviewed changes

eray-felek-sonarsource force-pushed the feature/ef/SLVS-2764-start-collecting-reqest-level-exceptions branch from 28c247f to 89a67a7 Compare January 6, 2026 16:12

eray-felek-sonarsource added 2 commits January 6, 2026 17:13

SLVS-2764 Start Collecting VS Exceptions

e38e42e

Rebase

65b9d6c

eray-felek-sonarsource force-pushed the feature/ef/SLVS-2764-start-collecting-reqest-level-exceptions branch from 89a67a7 to 65b9d6c Compare January 6, 2026 16:28

georgii-borovinskikh-sonarsource requested changes Jan 7, 2026

View reviewed changes

eray-felek-sonarsource added 2 commits January 7, 2026 11:24

First round of comments

560ec89

Second round of comments

c48e777

eray-felek-sonarsource force-pushed the feature/ef/SLVS-2764-start-collecting-reqest-level-exceptions branch from 868e45c to c48e777 Compare January 7, 2026 10:52

eray-felek-sonarsource changed the base branch from master to feature/ef/SLVS-enable-sentry January 7, 2026 10:53

georgii-borovinskikh-sonarsource approved these changes Jan 7, 2026

View reviewed changes

damien-urruty-sonarsource reviewed Jan 7, 2026

View reviewed changes

eray-felek-sonarsource added 3 commits January 7, 2026 15:33

Code review 3

ab05078

Limit Sentry collection to Internal Errors

45d3729

Fix tests

2da00f6

eray-felek-sonarsource requested a review from damien-urruty-sonarsource January 8, 2026 09:48

eray-felek-sonarsource added 2 commits January 8, 2026 17:33

Add error data

1e3eaed

Swallow Errors for older VS versions

1b9cd37

eray-felek-sonarsource force-pushed the feature/ef/SLVS-2764-start-collecting-reqest-level-exceptions branch from 66b1200 to 1b9cd37 Compare January 8, 2026 17:08

increase coverage

95de04c

georgii-borovinskikh-sonarsource reviewed Jan 9, 2026

View reviewed changes

src/SLCore/Core/IJsonRpc.cs Outdated Show resolved Hide resolved

georgii-borovinskikh-sonarsource reviewed Jan 9, 2026

View reviewed changes

PR Review

5b1d936

georgii-borovinskikh-sonarsource reviewed Jan 9, 2026

View reviewed changes

eray-felek-sonarsource merged commit 03158cf into feature/ef/SLVS-enable-sentry Jan 9, 2026
5 checks passed

eray-felek-sonarsource deleted the feature/ef/SLVS-2764-start-collecting-reqest-level-exceptions branch January 9, 2026 10:11

eray-felek-sonarsource added a commit that referenced this pull request Jan 9, 2026

SLVS-2764 Start collecting request level exceptions (#6578)

324c371

georgii-borovinskikh-sonarsource pushed a commit that referenced this pull request Jan 9, 2026

SLVS-2764 Start collecting request level exceptions (#6578)

7cce91e

SLVS-2764 Start collecting request level exceptions #6578

SLVS-2764 Start collecting request level exceptions #6578

Uh oh!

Conversation

eray-felek-sonarsource commented Jan 6, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

eray-felek-sonarsource Jan 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

georgii-borovinskikh-sonarsource left a comment

Choose a reason for hiding this comment

Uh oh!

georgii-borovinskikh-sonarsource left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Jan 9, 2026

SonarQube reviewer guide

Model A:

Model B:

Quality Gate passed

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

eray-felek-sonarsource Jan 7, 2026 •

edited

Loading