USER-1443 fix(S5254): Recognize JSP EL expressions as dynamic lang values #526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-1443)
S5254 was incorrectly triggering on child text elements when the lang
attribute on <html> was set via a JSP Expression Language expression
like `<html lang="${htmlLanguage}">`. The isDynamicValue() method now
recognizes `${...}` syntax as a dynamic value.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Opus 4.5 <[email protected]>
|
vdiez
approved these changes
Jan 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
langattribute on<html>was set via a JSP Expression Language expression like<html lang="${htmlLanguage}">${...}pattern recognition to theisDynamicValue()method inHelpers.javaTest plan
jspElExpressionShouldBeConsideredDynamic()that verifies no issues are raised for<html lang="${htmlLanguage}">🤖 Generated with Claude Code