Skip to content

🚧 Add signature contract step#230

Open
ewiggin wants to merge 10 commits into
masterfrom
NEW_add_signaturit_contract_flow
Open

🚧 Add signature contract step#230
ewiggin wants to merge 10 commits into
masterfrom
NEW_add_signaturit_contract_flow

Conversation

@ewiggin

@ewiggin ewiggin commented May 12, 2026

Copy link
Copy Markdown
Contributor

Description

Add signature contract step with feature flag, and add new SomStepper to gurb forms.

Changes

  • Add signature component
  • Refactor and unify signature component on NewContract and Gurb
  • Replace SomStepper with a new SomStepper component to unify a navigation functions

Checklist

Justify any unchecked point:

  • Changed code is covered by tests.
  • Relevant changes are explained in the "Unreleased" section of the CHANGES.md file.
  • That section includes "Upgrade notes" with any config, dependency or deploy tweek needed on development and server setups.
  • Changes on the setup process (development, testing, production) have been updated in the proper documentation

Testing

Test in local please:

  • Gurb requirements form works well
  • Gurb join form works well
  • With feature flag activate:
    • Signature steps appears
    • When signature step appears the lead is created
  • Without feature flag:
    • Form works as normally without signature step

Test in vercel:

With feature flag active:

  • Sign a document work
  • Activate lead works after sign

@vercel

vercel Bot commented May 12, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
webforms-ui Ready Ready Preview, Comment May 28, 2026 10:46am

Request Review

@ewiggin ewiggin changed the title 🚧 add signature contract step 🚧 Add signature contract step May 22, 2026
@ewiggin ewiggin requested a review from BenjiRS94 May 26, 2026 09:56

@dukenuken09 dukenuken09 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice Job!!! 👍

Comment thread src/components/Buttons/NextButton.jsx
Comment thread src/containers/Gurb/pages/Requirements/GurbRequirementsTariffSelection.jsx Outdated
Comment thread src/services/api.js Outdated
Comment thread src/containers/NewContractMember/NewContractMember.jsx Outdated
Comment thread src/containers/NewContractMember/NewContractMember.jsx
Added signature: true value to test files because
is an ERP's feature flag. Remove when all sync in master.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants