Implement transform.distribute() - #104
Merged
Merged
Conversation
Owner
|
Hi @Guflly! Thanks for the PR! Could you please add tests for all iterable containers? We should cover them all (Array, Set, Map, String, Generator, Iterable, Iterator, AsyncIterable, AsyncIterator) to match the test pattern we use for the other functions in this library. Thanks! |
Contributor
Author
|
Added the missing container coverage for Tests: 39 focused and 28,779 full passed. Coverage is 100%, and both builds pass. |
Owner
|
Hi @Guflly! Thank you for expanding the test coverage to include all the iterable types as well. I have merged your PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the sync and async distribute transforms plus
StreamandAsyncStreammethods. The result always containsnround-robin buckets, including empty buckets when needed.Includes tests and README examples.
Tests:
npm test -- --runInBand;npm run buildFixes #74