Resolves three open issues by implementing the required modules, fixing compilation errors, and closing a critical security bug.#537
Merged
Conversation
|
@JONAH-6 is attempting to deploy a commit to the smartdevs17's projects Team on Vercel. A member of the Team first needs to authorize it. |
Resolved conflict in oracle/src/services/index.ts by retaining upstream additions (TWAPService and ManipulationDetector exports).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What This PR Does
Resolves three open issues by implementing the required modules, fixing compilation errors, and closing a critical governance security bug.
Changes by File
contracts/hello-world/src/storage.rsGovernanceDataKey,DataKey, andGuardianConfigcontracts/hello-world/src/governance.rscontracts/hello-world/src/governance_test.rscontracts/hello-world/src/lib.rssrc/governance_test.rsis compiled correctlycontracts/lending/src/insurance.rsVecimports required by insurance pool logicSecurity Fix
The governance
vote()flow was vulnerable to flash-loan voting manipulation.Snapshot-based voting power was correctly calculated, but then overwritten using a live token balance, allowing temporary borrowed balances to influence governance voting.
This PR removes the overwrite and restores proper snapshot-based protection.
Testing
Closes #332
Closes #329
Closes #330
Closes #331