Fix release version not being set #43
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Looks good to me, lets see if I can find the "aprove merge" github button. |
Hoxolotl
approved these changes
Feb 10, 2026
Contributor
Hoxolotl
left a comment
Hoxolotl
left a comment
There was a problem hiding this comment.
Looks good. We'll move the artifacts back in if they're needed later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So... Turns out the Electron Forge reads the version from the
package.json. Since we do not set the version there (we use git instead), the publish command does not find a version. Hence thevundefinedrelease and the0.0.0filenames.This MR uses the
npm versioncommand to set the "version" key in thepackage.jsonto the value of the release's name. (Taken from the release event).