merge OpenSTA 3.0 upstream/master into silimate/main

.clang-format

@@ -10,7 +10,7 @@ AllowAllParametersOfDeclarationOnNextLine: false
 AllowShortIfStatementsOnASingleLine: Never
 AllowShortLoopsOnASingleLine: false
 AlwaysBreakAfterReturnType: TopLevel
-BinPackArguments: false
+BinPackArguments: true
 # fails
 BinPackParameters: AlwaysOnePerLine
 BraceWrapping:   
@@ -22,7 +22,7 @@ BreakBeforeBinaryOperators: NonAssignment
 BreakBeforeBraces: Custom
 # fails if all initializers fit on one line
 BreakConstructorInitializers: AfterColon
-ColumnLimit: 90
+ColumnLimit: 85
 # fails
 ConstructorInitializerIndentWidth: 2
 IncludeBlocks: Preserve

.clang-tidy

@@ -0,0 +1,82 @@
+Checks: >
+  clang-diagnostic-*,
+  clang-analyzer-*,
+  -clang-analyzer-core.NonNullParamChecker,
+  -clang-analyzer-core.CallAndMessage,
+  -clang-analyzer-core.uninitialized.UndefReturn,
+  -clang-analyzer-cplusplus.NewDeleteLeaks,
+  -clang-analyzer-optin.performance.Padding,
+  readability-*,
+  -readability-identifier-naming,
+  -readability-braces-around-statements,
+  -readability-convert-member-functions-to-static,
+  -readability-else-after-return,
+  -readability-function-cognitive-complexity,
+  -readability-inconsistent-ifelse-braces,
+  -readability-identifier-length,
+  -readability-implicit-bool-conversion,
+  -readability-isolate-declaration,
+  -readability-magic-numbers,
+  -readability-make-member-function-const,
+  -readability-math-missing-parentheses,
+  -readability-named-parameter,
+  -readability-qualified-auto,
+  -readability-redundant-access-specifiers,
+  -readability-simplify-boolean-expr,
+  -readability-static-definition-in-anonymous-namespace,
+  -readability-suspicious-call-argument,
+  -readability-uppercase-literal-suffix,
+  -readability-use-anyofallof,
+  google-*,
+  -google-readability-avoid-underscore-in-googletest-name,
+  -google-readability-braces-around-statements,
+  -google-readability-casting,
+  -google-readability-todo,
+  -google-runtime-references,
+  -google-explicit-constructor,
+  performance-*,
+  -performance-enum-size,
+  bugprone-*,
+  -bugprone-branch-clone,
+  -bugprone-easily-swappable-parameters,
+  -bugprone-exception-escape,
+  -bugprone-macro-parentheses,
+  -bugprone-move-forwarding-reference,
+  -bugprone-narrowing-conversions,
+  -bugprone-suspicious-missing-comma,
+  -bugprone-throwing-static-initialization,
+  modernize-*,
+  -modernize-avoid-bind,
+  -modernize-avoid-c-arrays,
+  -modernize-concat-nested-namespaces,
+  -modernize-macro-to-enum,
+  -modernize-pass-by-value,
+  -modernize-raw-string-literal,
+  -modernize-return-braced-init-list,
+  -modernize-use-auto,
+  -modernize-use-nodiscard,
+  -modernize-use-trailing-return-type,
+  -modernize-use-transparent-functors,
+  misc-*,
+  -misc-const-correctness,
+  -misc-multiple-inheritance,
+  -misc-no-recursion,
+  -misc-non-private-member-variables-in-classes,
+  -misc-redundant-expression,
+  -misc-unused-parameters,
+  -misc-use-anonymous-namespace,
+  -misc-use-internal-linkage,
+  -misc-include-cleaner
+
+# Only report diagnostics in headers under this tree (app/, include/sta/, build-generated
+# headers, etc.).
+# Excludes system and third-party paths such as /opt/local/include.
+HeaderFilterRegex: '.*/(app|cmake|dcalc|graph|liberty|network|parasitics|power|sdc|sdf|search|spice|tcl|util|verilog|include/sta|build/include/sta)/.*'
+
+# util/gzstream.hh
+# util/FlexDisableRegister.hh
+# Bison-generated parser headers (build/{Liberty,Verilog,...}Parse.hh)
+# Homebrew and MacPorts third-party headers.
+ExcludeHeaderFilterRegex: '(^/opt/(homebrew|local)/.*)|((.*/)?(gzstream\.hh|FlexDisableRegister\.hh|(Liberty|Verilog|Sdf|Spef|Saif|LibExpr)Parse\.hh)$)'
+SystemHeaders: false
+FormatStyle: none

.cursor/rules/cpp-coding-standards.mdc

@@ -0,0 +1,59 @@
+---
+description: C++ coding standards and formatting for OpenSTA
+globs: ["**/*.cc", "**/*.hh", "**/*.h"]
+alwaysApply: false
+---
+
+# C++ Coding Standards
+
+## Line Width
+
+- **Keep lines under 90 characters** to match `.clang-format` (ColumnLimit: 90).
+- Break long lines at logical points: after commas, before operators, after opening parens.
+
+## Naming Conventions
+
+- **Classes**: Upper camel case (`ClassName`)
+- **Member functions**: Lower camel case (`memberFunction`)
+- **Member variables**: Snake case with trailing underscore (`member_variable_`)
+- **Functions**: Lower camel case (`functionName`)
+- **Variables**: Snake case
+
+## Code Style
+
+- Use `#pragma once` for header guards.
+- Return type on the line before the function name; arguments on separate lines when long.
+- No braces for single-line if/for; use braces for multi-line bodies.
+- Prefer `std::string` over `char*` for string members.
+- Prefer pass-by-value and move for sink parameters (parameters that get stored).
+
+## File Extensions
+
+- C++ source: `.cc`
+- C++ headers: `.hh`
+
+## Include order
+
+Sort `#include` lines **lexicographically by the path inside** `<>`
+or `""` (case-sensitive). Separate **groups** with a single blank line.
+
+### Translation units (`*.cc`)
+
+1. **Primary header(s)** for this file only:
+   - `#include "Stem.hh"` where `Stem` matches the basename of the `.cc` file (e.g. `Foo.cc` → `Foo.hh`).
+   - If the file uses a paired private header, include `#include "StemPvt.hh"` **immediately after** `Stem.hh` (e.g. `MakeTimingModel.cc` → `MakeTimingModel.hh` then `MakeTimingModelPvt.hh`).
+   - Do **not** pull in other headers just because their names share a prefix with `Stem` (e.g. `SearchClass.hh` is not a “primary” include for `Search.cc`; it belongs in the project group below).
+
+2. **System / standard library** headers: `#include <...>` lines, sorted alphabetically.
+
+3. **All other project** headers: `#include "..."` lines, sorted alphabetically (including `search/Crpr.hh`-style paths and includes from `liberty/`, etc.).
+
+If a **comment or special block** intentionally splits the include list (e.g. a third-party note before `#include "cudd.h"`), keep that structure; sort only within each contiguous run of `#include` lines unless merging groups is clearly safe.
+
+### Headers (`*.hh`)
+
+After `#pragma once` (and the file’s license block, if present):
+
+1. **System** `#include <...>` lines, sorted alphabetically.
+
+2. **Project** `#include "..."` lines, sorted alphabetically.

.cursor/rules/cpp-indentation.mdc

@@ -0,0 +1,43 @@
+---
+description: C++ function call indentation for OpenSTA
+globs: ["**/*.cc", "**/*.hh", "**/*.h"]
+alwaysApply: false
+---
+
+# C++ Function Call Indentation
+
+## Short Calls — Single Line
+
+When arguments fit within the column limit (90 chars), keep them on one line:
+
+```cpp
+// ✅ GOOD
+adjusted_data_arrival = delaySum(required, data_shift_to_enable_clk, this);
+
+// ❌ BAD
+adjusted_data_arrival = delaySum(required,
+                 data_shift_to_enable_clk,
+                 this);
+```
+
+## Nested Function Calls — Align Under Inner Call
+
+When breaking nested calls across lines:
+- Indent continuation lines of the inner call under its first argument (align with content after `innerFunc(`).
+- Place remaining outer arguments on the same line as the inner call's closing `)`, indented under the outer function.
+
+```cpp
+// ✅ GOOD
+required = delayDiff(delaySum(max_delay,
+                              search_->clkPathArrival(disable_path),
+                              this),
+                     margin, this);
+
+// ❌ BAD
+required = delayDiff(
+             delaySum(max_delay,
+                      search_->clkPathArrival(disable_path),
+                      this),
+             margin,
+             this);
+```

.cursor/rules/opensta-tests.mdc

@@ -0,0 +1,13 @@
+---
+description: Where OpenSTA regression tests live (pvt/test vs public test/)
+alwaysApply: true
+---
+
+# OpenSTA tests and regression
+
+- **Primary suite:** Most regression tests, Tcl drivers, and golden `.ok` files live under **`pvt/test/`** (private / separate repo, often opened as a second workspace root alongside `master`).
+- **Public subset:** **`test/`** at the OpenSTA repo root holds a smaller set of tests shipped with the public tree (e.g. `test/regression`, `*.tcl`, `*.ok` there).
+
+When searching for a test name, regression lists, or updating goldens, **check `pvt/test` first**, then `test/`.
+
+Typical driver: `pvt/test/regression` (or `test/regression` for the public list). Built `sta` binary is usually `master/build/sta` relative to the main checkout.

.github/dependabot.yml

@@ -0,0 +1,6 @@
+version: 2
+updates:
+  - package-ecosystem: github-actions
+    directory: "/"
+    schedule:
+      interval: "daily"

.github/workflows/ci.yml

@@ -0,0 +1,55 @@
+name: CI
+
+on:
+  push:
+  pull_request:
+
+jobs:
+  build:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v6
+        with:
+          submodules: true
+
+      - name: Set up dependencies
+        run: |
+          sudo apt-get update && sudo apt-get install -y flex libfl-dev bison tcl-dev tcl-tclreadline libeigen3-dev ninja-build
+
+      - name: Set up cudd-3.0.0
+        run: |
+          wget https://github.com/oscc-ip/artifact/releases/download/cudd-3.0.0/build.tar.gz
+          mkdir -p cudd
+          tar -zxvf build.tar.gz -Ccudd
+
+      - name: Build
+        run: |
+          mkdir build
+          cd build
+          cmake .. -G Ninja -DCUDD_DIR=$(pwd)/../cudd -DCMAKE_INSTALL_PREFIX=$(pwd)/install -DCMAKE_BUILD_TYPE=Release
+          cmake --build . --target all -- -j $(nproc)
+          cmake --install .
+          tar -zcvf build.tar.gz -Cinstall .
+
+      - name: Test
+        run: |
+          cd test
+          ./regression
+
+      - name: Upload Artifacts
+        uses: actions/upload-artifact@v7
+        if: ${{ !cancelled() }}
+        with:
+          name: artifact
+          path: |
+            build/install/*
+          retention-days: 1
+
+      - name: Upload Test Result
+        uses: actions/upload-artifact@v7
+        if: ${{ !cancelled() }}
+        with:
+          name: result
+          path: |
+            test/results/*

.github/workflows/tests.yaml

@@ -20,7 +20,7 @@ jobs:
           docker run --entrypoint /bin/bash --tty --rm sta-${{ matrix.os }} -c "cd /OpenSTA/test && (./regression || (cat results/diffs && exit 1)) || (./regression -collections || (cat results/diffs && exit 1))"
 
   macos:
-    runs-on: [macos-14]
+    runs-on: [macos-15]
     timeout-minutes: 5
     steps:
       - uses: actions/checkout@v4