Repository navigation
fix(game-screen): swipe in from the left edge for brightness, or nothing - #9
Open
thewhoareyou wants to merge 6 commits into
Open
thewhoareyou wants to merge 6 commits into
thewhoareyou wants to merge 6 commits into
Conversation
…to trackpad mode The brightness slider could only be opened by touching the left edge of the screen, which took that strip away from the game even when touches go to the host where they land. The edge now opens it only with the touchscreen as a trackpad. The overlay menu has a Brightness button instead, which closes the menu and opens the slider focused for a gamepad or remote: up and down (d-pad, hat or left stick, repeating when held) step the brightness to the next multiple of 5%, touch still moves it by 1%, and A, B, centre, Enter or Back close it. The key that closes it is taken on release too, and no other input reaches the stream while it's up. It stays up until closed, or until the stream is touched, and focus goes back to the stream after. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit d9b439c)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit fcc1e48)
…menu settings A swipe in from the left edge opens the overlay menu or the brightness slider, or does nothing, as the new Left edge swipe action setting says (brightness by default). Unlike the tap it replaces, it works in direct touch mode and with the on-screen controls, since it only triggers once the finger has swiped in. The 3-finger tap still opens the overlay menu. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit 102bc5d)
The timer only starts once the brightness has been changed, and now runs when the slider was opened from the overlay menu too. Until then it stays up; a touch on the stream closes it, however it was opened. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit 3e6665e)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #3's first complaint — "the brightness bar in the left is annoying and it can not be disabled" — by porting Moonlight X's own solution, taken with
git cherry-pick -x:Upstream commits:
d9b439c0,fcc1e48f,102bc5da,3e6665e7.82e820f8was skipped — it's102bc5da's parent (suppressing the old tap under on-screen controls) and the swipe commit deliberately removed that gate, since a real swipe can't come from an OSC button.Port notes: upstream's jitter-buffer menu tile was dropped from the conflicts (Starwire has jitter as a per-game setting, not a menu tile), and the Brightness tile was mapped onto Starwire's tile-grid menu. The swipe's shape check is extracted as
Game.edgeSwipeCompletefor unit tests.Test plan
GameRulesTest9/9, including new swipe-geometry coverage (tap ≠ swipe, vertical scroll ≠ swipe, density scaling); 316-test suite otherwise clean apart from the known macOSCustomVulkanDriverImportTestpath failureslintNonRootDebugclean,assembleNonRootDebugbuildsGenerated with Devin