Add dalli gem to prevent warnings from idenity_cache
#2498
Merged
+2,468
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Proposing we add
dallito our Gemfile to prevent the following warnings from appearing in CI logs.You don't have dalli installed in your application. Please add it to your Gemfile and run bundle installConfirmed the above warning appears in all CI run logs for all Ruby/Rails versions by downloading the logs from a recent successful CI run and
grep-ing over them for the above warning with the following.grep -n "dalli" /home/larouxn/Downloads/logs_55022312394/*.txtInspired by #2155 (comment), as I believe
identity_cachemay be the source of the warnings re: it uses dalli.Implementation
dallito Gemfilebundle installTests
I have confirmed the warning no longer appears in logs when
dalliis present in the Gemfile.https://github.com/larouxn/tapioca/actions/runs/21225302153