Skip to content

Conversation

@larouxn
Copy link
Contributor

@larouxn larouxn commented Jan 21, 2026

Motivation

Proposing we add dalli to our Gemfile to prevent the following warnings from appearing in CI logs.

You don't have dalli installed in your application. Please add it to your Gemfile and run bundle install

Confirmed the above warning appears in all CI run logs for all Ruby/Rails versions by downloading the logs from a recent successful CI run and grep-ing over them for the above warning with the following.

grep -n "dalli" /home/larouxn/Downloads/logs_55022312394/*.txt

Inspired by #2155 (comment), as I believe identity_cache may be the source of the warnings re: it uses dalli.

Implementation

  1. Add dalli to Gemfile
  2. bundle install

Tests

I have confirmed the warning no longer appears in logs when dalli is present in the Gemfile.

https://github.com/larouxn/tapioca/actions/runs/21225302153

@larouxn larouxn requested a review from a team as a code owner January 21, 2026 21:41
@rafaelfranca rafaelfranca added the dependencies Pull requests that update a dependency file label Jan 21, 2026
@rafaelfranca rafaelfranca merged commit 7baaee1 into Shopify:main Jan 21, 2026
19 of 20 checks passed
@larouxn larouxn deleted the add_dalli_gem_to_prevent_warnings branch January 21, 2026 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants