Skip to content

Conversation

@caleb
Copy link
Contributor

@caleb caleb commented Jan 21, 2026

Motivation

The delete_by and destroy_by ActiveRecord methods take multiple arguments (like where) instead of a single argument.

Implementation

I just replaced create_param with create_rest_param and updated the tests

Tests

I updated the tests to expect the rest argument instead of a single argument

@caleb caleb requested a review from a team as a code owner January 21, 2026 20:49
@rafaelfranca
Copy link
Member

I can't see the tests changes. Did you forget to push?

@caleb
Copy link
Contributor Author

caleb commented Jan 21, 2026

@rafaelfranca Ha! Yeah, it's there now.

Copy link
Member

@paracycle paracycle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for fixing this.

@paracycle paracycle enabled auto-merge January 21, 2026 23:41
@paracycle paracycle merged commit 3fbd33e into Shopify:main Jan 22, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants