Skip to content

[Fix] Correct underscore_to_dot parameter for nanbeige3.5-pro-thinking #1269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
HuanzhiMao merged 3 commits into from
Jan 3, 2026
Merged

[Fix] Correct underscore_to_dot parameter for nanbeige3.5-pro-thinking #1269

HuanzhiMao merged 3 commits into from
Jan 3, 2026
+5 −17

Conversation

@fffflust
Copy link
Contributor

@fffflust fffflust commented Dec 17, 2025

Issue: underscore_to_dot was incorrectly set to False (should be True)

Fix: Set underscore_to_dot=True for nanbeige3.5-pro-thinking

Note: Only re-evaluation needed, no re-generation required

@HuanzhiMao HuanzhiMao added the BFCL-General General BFCL Issue label Jan 3, 2026
HuanzhiMao
HuanzhiMao approved these changes Jan 3, 2026
View reviewed changes
Copy link
Collaborator

@HuanzhiMao HuanzhiMao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HuanzhiMao HuanzhiMao merged commit 9b8a520 into ShishirPatil:main Jan 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HuanzhiMao HuanzhiMao HuanzhiMao approved these changes

Assignees

No one assigned

Labels

BFCL-General General BFCL Issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fffflust @HuanzhiMao