test: add tests for unprotected behavior

[nilsreichardt]

Added unit tests for critical unprotected behavior in the hausaufgabenheft_logik domain package.

What behavior is now protected:

• Date calculations: Comparisons, overrides with clock, and day additions handling month/year boundaries (in Date model).
• Scheduling logic: BaseHomeworkReadModel isOverdueRelativeTo check to accurately determine if homework is past due relative to the active date.
• Sorting and Categorization: The HomeworkSortAndSubcategorizer logic mapping sorting strategies (SmallestDateSubjectAndTitleSort, SubjectSmallestDateAndTitleSort, WeekdayDateSubjectAndTitleSort) to distinct list sections (e.g. 'Heute', 'Überfällig').
• Domain constraints: Instantiating Subject with an empty name properly throws an ArgumentError.

What bugs it would catch:

• Incorrect homework showing up in wrong date-based groups (like showing past due as today, or next month homework showing up prematurely).
• Errors navigating week boundaries or end-of-year rollovers for due dates.
• Silent failures or downstream errors when creating subjects with invalid/empty names.
• Sorting discrepancies where homework isn't properly clustered by subject or weekday.

---

PR created automatically by Jules for task 3608123647689827036 started by @nilsreichardt

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[gemini-code-assist]

Code Review

This pull request adds a comprehensive suite of unit tests for critical unprotected behavior in the hausaufgabenheft_logik domain package. The tests are well-structured and cover important functionality related to date calculations, scheduling logic, sorting, and domain constraints. My feedback focuses on improving the maintainability and readability of the new test code by reducing code duplication and replacing magic values with named constants, which will make the tests more robust and easier to manage in the future. All original comments have been retained as they do not contradict any provided rules.

[gemini-code-assist]

The creation of _TestHomework is very repetitive across the tests in this group. To reduce boilerplate and improve maintainability, consider extracting the object creation into a helper function. This function could take the todoDate as a parameter, since that's the main property that varies between tests.

For example:

_TestHomework createHomework(DateTime todoDate) {
  return _TestHomework(
    id: HomeworkId('hw-1'),
    title: title,
    subject: subject,
    courseId: CourseId('course-1'),
    withSubmissions: false,
    todoDate: todoDate,
  );
}

[gemini-code-assist]

There is significant repetition in the creation of _TestHomework instances for test data. To make the test setup more concise, readable, and maintainable, consider creating a helper function. This function could take parameters for the properties that vary between homework items, such as id, title, subject, and todoDate.

For example:

_TestHomework createHomework({
  required String id,
  required String title,
  required Subject subject,
  required DateTime todoDate,
}) {
  return _TestHomework(
    id: HomeworkId(id),
    title: Title(title),
    subject: subject,
    courseId: CourseId('c-1'),
    withSubmissions: false,
    todoDate: todoDate,
  );
}

[gemini-code-assist]

To avoid using a magic string and to make the test more robust against changes to the test data, it's better to use englishSubject.name here instead of the literal 'English'. This ensures that if the subject name in the test setup changes, this check will automatically update.

Suggested change

	final englishSection = result.firstWhere((s) => s.title == 'English');
	final englishSection = result.firstWhere((s) => s.title == englishSubject.name);

[gemini-code-assist]

To avoid using a magic string and to make the test more robust against changes to the test data, it's better to use mathSubject.name here instead of the literal 'Math'. This ensures that if the subject name in the test setup changes, this check will automatically update.

Suggested change

	final mathSection = result.firstWhere((s) => s.title == 'Math');
	final mathSection = result.firstWhere((s) => s.title == mathSubject.name);

[gemini-code-assist]

Using the magic number 1 for Monday is less readable than using the DateTime.monday constant. Using the constant makes the code more self-documenting.

Suggested change

	final mondaySection = result.firstWhere((s) => s.weekday == 1);
	final mondaySection = result.firstWhere((s) => s.weekday == DateTime.monday);

[gemini-code-assist]

Using the magic number 2 for Tuesday is less readable than using the DateTime.tuesday constant. Using the constant makes the code more self-documenting.

Suggested change

	final tuesdaySection = result.firstWhere((s) => s.weekday == 2);
	final tuesdaySection = result.firstWhere((s) => s.weekday == DateTime.tuesday);

[gemini-code-assist]

Using the magic number 3 for Wednesday is less readable than using the DateTime.wednesday constant. Using the constant makes the code more self-documenting.

Suggested change

	final wednesdaySection = result.firstWhere((s) => s.weekday == 3);
	final wednesdaySection = result.firstWhere((s) => s.weekday == DateTime.wednesday);

[gemini-code-assist]

Using the magic number 6 for Saturday is less readable than using the DateTime.saturday constant. Using the constant makes the code more self-documenting.

Suggested change

	final saturdaySection = result.firstWhere((s) => s.weekday == 6);
	final saturdaySection = result.firstWhere((s) => s.weekday == DateTime.saturday);

[gemini-code-assist]

Using the magic number 7 for Sunday is less readable than using the DateTime.sunday constant. Using the constant makes the code more self-documenting.

Suggested change

	final sundaySection = result.firstWhere((s) => s.weekday == 7);
	final sundaySection = result.firstWhere((s) => s.weekday == DateTime.sunday);

[github-actions]

Visit the preview URL for this PR (updated for commit d075177):

https://sharezone-console-dev--pr2209-jules-homework-domai-1mmlj753.web.app

_{(expires Wed, 11 Mar 2026 16:49:31 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: 471536afe3f6ec4895d9ea75513730b515d17eb6}

[github-actions]

Visit the preview URL for this PR (updated for commit d075177):

https://sharezone-website-dev--pr2209-jules-homework-domai-wwd1k1ic.web.app

_{(expires Wed, 11 Mar 2026 16:49:40 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: 372b0431a96247f908d9a97d5d865de1c8b3b04e}

[github-actions]

Visit the preview URL for this PR (updated for commit d075177):

https://sharezone-test--pr2209-jules-homework-domai-39r9ni9y.web.app

_{(expires Wed, 11 Mar 2026 16:50:35 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: 4cb3ae61e1e018abfd9841fd3239f5b49ccc034b}