Bugfix: Repeated breadcrumb issue#60
Merged
Garneauma merged 5 commits intoServiceCanada:mainfrom Apr 16, 2026
Merged
Conversation
Yves-Denis
previously approved these changes
Mar 5, 2026
Yves-Denis
left a comment
There was a problem hiding this comment.
Security Assessment Completed - Passed, no issues identified
GormFrank
previously requested changes
Mar 6, 2026
Co-authored-by: Francis Gorman <francis.gorman25@gmail.com>
Co-authored-by: Francis Gorman <francis.gorman25@gmail.com>
Garneauma
requested changes
Apr 13, 2026
Contributor
Garneauma
left a comment
There was a problem hiding this comment.
@cfoss-coveo Tested locally with a few sample searches. It does remove the duplication of breadcrumb items compared to the live search on Canada.ca.
Only one small technical change. Thanks!
Moved the `ol` tag outside the breadcrumb conditional Co-authored-by: Garneauma <garneauma@gmail.com>
Garneauma
approved these changes
Apr 16, 2026
Yves-Denis
approved these changes
Apr 16, 2026
Yves-Denis
left a comment
There was a problem hiding this comment.
Further Security review completed - no issues identified.
ipaksc
approved these changes
Apr 16, 2026
Contributor
ipaksc
left a comment
There was a problem hiding this comment.
Tested in production using a test page. Everything works as expected.
Reviewed by @Garneauma , @ipaksc and @Yves-Denis
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tickets/Tasks:
Description:
Cause:
<a href="https://www.canada.ca">www.canada.ca</a>.canada.ca > www.canada.caTesting:
@wordcount==1in the Content Browser. Identify an item, then try to bring it up on the search results. Before, you'd see the address repeated:bst-tsb.gc.ca > www.bst-tsb.gc.ca. Now, you'll just see the hostname:bst-tsb.gc.ca