Mitigate the use of inline style as a CSS class#36
Mitigate the use of inline style as a CSS class#36duboisp merged 1 commit intoServiceCanada:lts-updatefrom
Conversation
duboisp
left a comment
There was a problem hiding this comment.
Reviewed and tested the build script update, it does generate the css file as expected.
I did a functional test via my github pages and the added css class are not applied to the page, there is an issue with the path of the css file.
A few additional content change are requires.
Path is now adjusted, it's working now on gihub pages: https://polmih.github.io/oag-template/examples/oag-inline-style-to-classes.html |
duboisp
left a comment
There was a problem hiding this comment.
I can see the stylesheet to be added now and the warning message seem to be descriptive enough.
But I can't find the oag-purple-trillium css class. It was probably not released yet. For our immediate need, can you create that style as a temporary CSS for now.
Thanks
duboisp
left a comment
There was a problem hiding this comment.
One small content change.
- Complement the description inside the danger notice to match and have it aligned with the description in the CSS file.
Other than that, we should be good after to initiate a release based on the latest tag v1.3.1. That may require to adjust the base branch for this PR and then cloning this PR. I will help with that technicality.
duboisp
left a comment
There was a problem hiding this comment.
Look good,
I reviewed and tested and it work as expected.
Description: Mitigate the use of inline style via a temporary strategy because inline style applied through the font element are going to lost their effect after our upcoming content management system upgrade.
Impact on the sponsored department: The removal of those temporary style will be added into their maintenance plan and they will need to replace them and fix their pages by using a long term solution.
Impact on the public: None, content will be rendered as it is currently.
WET-657 related