security: mitigate SQL injection in vector index management - #2291
Open
inco308 wants to merge 1 commit into
Open
security: mitigate SQL injection in vector index management#2291inco308 wants to merge 1 commit into
inco308 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2290
Summary
This PR fixes a SQL injection issue in
PostgresChunksHandlerby applying strict validation and safe quoting to all user-supplied database identifiers used in index management. It prevents arbitrary SQL injection viaindex_columnandindex_name.Changes
psql_quote_identifierutility inpy/core/providers/database/utils.pyto safely double-quote SQL identifiers.index_columnincreate_index(only allow known column names).index_namewith regex (^[A-Za-z0-9_]+$) and length limits (max 63 chars).create_indexanddelete_index.How to test
pytest py/tests/unit/database/test_security.py— ensures maliciousindex_name/index_columnraiseValueErrorand do not lead to execution.public.poc_success_executedtable is created in the database.Compatibility & migration
Security note
AuthConfig.require_authentication = Truefor production and restricting/v3/indicesto RBAC-managed roles.