Feat edit annotations - #607
Open
robertwidfen wants to merge 13 commits into
Open
Conversation
robertwidfen
force-pushed
the
feat/edit_annotations
branch
2 times, most recently
from
August 10, 2026 06:43
3b39232 to
efae3fb
Compare
This was
linked to
issues
Aug 10, 2026
10 tasks
Select annotations items with pointer tool. Delete annotation with Delete. Nudge selected annotation by cursor keys. Pointer tool click raises annotation to top. Double-click to edit text annotation. Alt+Click selects overlapping annotations, but does not raise the annotation. If (Alt+)Click without Ctrl hits an annotation starts temporary pointer tool.
Relying on undo is not sufficient when markers have been deleted.
Updates toolbar styles based on slected annotation and update annotation with toolbar style changes. Other changes: - Always draw stroke, otherwise with fill-only the shape of rectangle and ellipse will shrink. - Update selection bounds after redraw as with text we do not know the new size until redraw.
Got lost in the restyle commit.
Scrol up to raise and down to lower.
Got lost somewhere during rebasing.
robertwidfen
force-pushed
the
feat/edit_annotations
branch
from
August 15, 2026 09:19
efae3fb to
a30f086
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows to modify annotation after they have been committed. Position, size, color, style ... edit text annotations, change number of marker, nudge selection by keyboard, ...
Fixes:
Sits on #606.
Would be great if some can test it before we merge it.
Touches many places.
Rectangle
recording_20260808_231406.mp4
Arrow and Marker
recording_20260808_231546.mp4
Text
recording_20260808_231630.mp4