Skip to content

Contributions: clarify requirements to PRs - #351

Open
RobertMueller2 wants to merge 3 commits into
Satty-org:mainfrom
RobertMueller2:refresh_contributing
Open

Contributions: clarify requirements to PRs#351
RobertMueller2 wants to merge 3 commits into
Satty-org:mainfrom
RobertMueller2:refresh_contributing

Conversation

@RobertMueller2

Copy link
Copy Markdown
Member

No description provided.

@RobertMueller2
RobertMueller2 requested a review from gabm November 30, 2025 21:20
@RobertMueller2
RobertMueller2 force-pushed the refresh_contributing branch 2 times, most recently from bbe88c8 to 21e93c3 Compare November 30, 2025 21:44

@gabm gabm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

like it, maybe add the git command?

Comment thread .github/pull_request_template.md Outdated
@RobertMueller2
RobertMueller2 force-pushed the refresh_contributing branch 2 times, most recently from 3b38795 to d0aac46 Compare December 1, 2025 13:57
@RobertMueller2

Copy link
Copy Markdown
Member Author
  • request conventional commit messages at least for the first commit in a PR
  • request breakage/disruption attention (!) and description of the breakage/disruption for later inclusion in the release notes

@RobertMueller2
RobertMueller2 force-pushed the refresh_contributing branch 3 times, most recently from e2a9653 to 3157483 Compare February 18, 2026 10:21
@RobertMueller2
RobertMueller2 force-pushed the refresh_contributing branch 3 times, most recently from 08ba183 to 6ceca8b Compare March 14, 2026 06:16
@RobertMueller2
RobertMueller2 force-pushed the refresh_contributing branch from 3f409fb to fadf967 Compare May 14, 2026 05:13

@robertwidfen robertwidfen left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer a more template like structure maybe even with sections - but I am not much into this so far ...

Comment thread .github/pull_request_template.md Outdated
Comment thread .github/pull_request_template.md Outdated

tl;dr:

- please make sure all commits compile

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer a checklist:

  • all commits compile
  • all commits use conventional commit messages
  • (re)based onto main
  • includes breaking changes
  • includes LLM/Generative AI code
  • I vouch for the code

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer a checklist:

* [ ]  all commits use [conventional commit messages](https://www.conventionalcommits.org/)

I'll scrap that, if we squash anyway it's not needed.

* [ ]  (re)based onto [main](https://github.com/Satty-org/Satty/tree/main)

This may need recurrence depending on how long a PR takes, I might rephrase that :)

@RobertMueller2
RobertMueller2 force-pushed the refresh_contributing branch from fadf967 to 4fee758 Compare July 3, 2026 07:04
@lumi-me-not

Copy link
Copy Markdown

Hello! :)

I just found out about Satty and it looks really cool!

For many reasons, I am against LLMs (and GenAI as a whole), including ethical, environmental and practical ones. Would the project consider implementing a ban on GenAI?

If this is done, the project could also be featured on lists like https://noai.starlightnet.work .

@gabm

gabm commented Jul 29, 2026

Copy link
Copy Markdown
Member

Hey @lumi-me-not ,

it is true that we do not have a lot of AI contributions so far. We want that the authors at least understand AI generated contributions, change them according to the comments and adjust them, so that maintainability can be secured.

We understand code as a mean to achieve certain goals, but also as a form of expression - maybe even "art". That being said, we need to accept the world we live in and the strengths that GenAI gives us. Therefore, we think that prohibiting GenAI is neither achievable nor sensible. We will not implement a ban on GenAI.

Wish you luck with your quest against GenAI, we feel with you - but we cannot support you.

Best,
gabm

@lumi-me-not

Copy link
Copy Markdown

Thanks for the swift response! :)

Personally, I believe that the possible upsides are massively outweighed by all of the downsides, especially systemically. I also believe a ban is achievable, see https://cyrneko.eu/ai-policy.html

That being said, I understand your views and will respect them, I'll just ask to see my input as a datapoint against GenAI. :)

Wish the project & all of you the best. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants