Skip to content

Update Annotation Size Spinner Step - #284

Closed
agata wants to merge 1 commit into
Satty-org:mainfrom
agata:feature/annotation-size-step
Closed

Update Annotation Size Spinner Step#284
agata wants to merge 1 commit into
Satty-org:mainfrom
agata:feature/annotation-size-step

Conversation

@agata

@agata agata commented Sep 30, 2025

Copy link
Copy Markdown
Contributor

Summary

Adjusted the annotation size dialog so the spinner buttons jump in whole-number increments instead of 0.01 steps.

Most people tweaking annotation sizes are looking for a visibly larger or smaller mark, not a fractional change they can’t perceive. Switching the spinner to whole-number steps matches that expectation, gets them to the desired size faster, and keeps the dialog from feeling unnecessarily fussy.

Testing Notes

  • Manual: Opened the annotation size dialog and confirmed that the up/down arrows now change the value by ±1.

@RobertMueller2

Copy link
Copy Markdown
Member

OK, the defaults aren't good, you definitely got a point there. I'm not opposed to improving them. But I'm using decimal adjustments all the time, so I'm slightly reluctant to just overwrite it with an integer value. 😄

This definitely has some overlap with #178, #171, doesn't mean we need to wait for them, but there's a chance whatever we do here will be overridden in the future.

I'm not sure if we ever find a sensible default that works for all image sizes, so I'm kinda thinking, can we perhaps set the adjustment and acceleration depending on image size? (And yes, that will add an additional problem if we ever allow to open images after starting, but we can deal with that once we cross that bridge.)

@agata

agata commented Oct 8, 2025

Copy link
Copy Markdown
Contributor Author

I’ve checked #178 and #171, and I think they’re addressing the same underlying issue.
I like the idea of switching via a button — that’s a nice improvement. It would be even better if it could be changed without opening a dialog.

Some similar tools allow the entered text to become selected after input, so it can be moved or resized with a handler. Personally, I prefer that approach, though I imagine it would be more challenging to implement.

@robertwidfen

Copy link
Copy Markdown
Collaborator

Please check out the merged PR #549. It removes the dialog and adds increments of 1.0, 0.1, and 0.01 steps (details are in the README.md). A middle-click on +/- uses a 1.0 step size, while the default is 0.1.

I noticed you added set_climb_rate: 1.0 in your changes. I missed that in my PR, so I'll bring it back! However, 1.0 feels a bit too fast for me - I keep overshooting the target value. 😉

Also, I'm not entirely sure if a step size of 5.0 is intuitive here. What do you think?

robertwidfen added a commit to robertwidfen/Satty that referenced this pull request Jun 23, 2026
- Holding Ctrl now changes the step size to 1.0.
- Restore set_climb_rate to 0.1 (previously lost in PR Satty-org#549).

Thanks to PR Satty-org#284 for the inspiration, but a climb rate of 1.0
is IMHO a bit too much.
robertwidfen added a commit that referenced this pull request Jun 24, 2026
- Holding Ctrl now changes the step size to 1.0.
- Restore set_climb_rate to 0.1 (previously lost in PR #549).

Thanks to PR #284 for the inspiration, but a climb rate of 1.0
is IMHO a bit too much.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants