Security/cancel hunt callback fix#572
Open
theFirstCodeManiac wants to merge 16 commits into
Open
Conversation
…encoded timestamps and bit flags
…delta-encoded timestamps
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #78
Pull Request
Summary
Fix a critical authorization vulnerability in
cancel_huntby requiring cryptographic authentication from the hunt creator before allowing cancellation.Changes Made
require_auth()for the caller incancel_huntProblem
The previous implementation only compared the supplied caller address with
hunt.creatorwithout verifying that the caller actually controlled that address. This allowed an attacker to spoof the creator's address and cancel hunts they did not own.Solution
The function now invokes
require_auth()before performing ownership checks, ensuring the transaction is authorized by the creator's account.Testing
Security Impact
This change closes a critical authorization bypass by enforcing cryptographic authentication, preventing unauthorized hunt cancellations through address spoofing.