Open
Conversation
pnowojski
reviewed
Nov 3, 2025
| } | ||
|
|
||
| public void copyFiles( | ||
| List<PathsCopyingFileSystem.CopyRequest> requests, ICloseableRegistry closeableRegistry) |
There was a problem hiding this comment.
You should use closeableRegistry to handle cancellations.
pnowojski
reviewed
Nov 3, 2025
| private final S3TransferManager transferManager; | ||
| private final int maxConcurrentCopies; | ||
|
|
||
| public NativeS3BulkCopyHelper(S3TransferManager transferManager, int maxConcurrentCopies) { |
There was a problem hiding this comment.
I think you should include the optional dependency of aws-crt
Samrat002
force-pushed
the
native-fs-s3
branch
3 times, most recently
from
a556415 to
bcdcf46
Compare
Samrat002
force-pushed
the
native-fs-s3
branch
2 times, most recently
from
481b28d to
7afeca8
Compare
Samrat002
force-pushed
the
native-fs-s3
branch
from
8b3e619 to
3c665ec
Compare
Samrat002
force-pushed
the
native-fs-s3
branch
2 times, most recently
from
15dacc2 to
434aaeb
Compare
Samrat002
force-pushed
the
native-fs-s3
branch
3 times, most recently
from
7786f0e to
2a1de0a
Compare
Support s3a scheme Address to review comments
Samrat002
force-pushed
the
native-fs-s3
branch
from
2a1de0a to
bfd81d2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setup and testing details
Callout :
Outcome
Able to verify read, write and checkpointing using the native-s3-filesystem
Jobmanager log: https://drive.google.com/file/d/1lfEJRn9F-r72YgU_uyyQFlEg2VAN_3qJ/view?usp=sharing
TaskManager log :
taskmanager-1.log