fix: replace alert/confirm with inline toast and modal for profile ops#307
fix: replace alert/confirm with inline toast and modal for profile ops#307Kirtan-pc wants to merge 1 commit into
Conversation
Profile and backup operations in settings.js previously used native
window.alert() and window.confirm() which surface as OS-level blocking
modals. These are inconsistent with the dark-themed settings UI and
block the Electron renderer thread.
Changes:
- Add showProfileStatus(elementId, message, isError, persistent) helper
that renders a styled, auto-dismissing inline banner beneath each
operation group (theme profiles, settings backup, aurora engine
profiles), mirroring the existing showHotkeyStatus() pattern.
- Add showInlineConfirm(message) Promise-based helper that shows a
dark-themed, non-blocking modal overlay instead of window.confirm().
Clicking outside or Cancel resolves false; clicking Confirm resolves
true. Falls back to window.confirm() if DOM elements are absent.
- Add three .profile-status-msg elements in settings.html:
#profile-status-msg (Theme Profiles section)
#backup-status-msg (Settings Backup section)
#aurora-status-msg (Aurora Engine Profiles section)
- Add #inline-confirm-modal overlay in settings.html.
- Add .profile-status-msg and .inline-confirm-overlay CSS in
settings.css with slide-in animation and error/success colour coding.
- Replace every alert() / confirm() call in profile save, delete,
duplicate, import, export, backup export/import, restore defaults,
aurora engine profile save/load/delete, and gradient-stop limit
with the new helpers.
Fixes: alert/confirm blocking OS modals in Electron renderer
|
@Kirtan-pc is attempting to deploy a commit to the Dot_NotSam's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Profile and backup operations in settings.js previously used native window.alert() and window.confirm() which surface as OS-level blocking modals. These are inconsistent with the dark-themed settings UI and block the Electron renderer thread.
Changes:
#backup-status-msg (Settings Backup section)
#aurora-status-msg (Aurora Engine Profiles section)
settings.css with slide-in animation and error/success colour coding.
duplicate, import, export, backup export/import, restore defaults,
aurora engine profile save/load/delete, and gradient-stop limit
with the new helpers.
Fixes Issue #279