Skip to content

Fix: Implement comprehensive resource clean-up system to prevent memory leaks #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Puneet04-tech wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: Implement comprehensive resource clean-up system to prevent memory leaks #306

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 46 additions & 4 deletions renderer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,6 +224,11 @@ let visualizerState = {
const params = new URLSearchParams(window.location.search);
const debugEnabled = params.get("debug") === "1";

// Cleanup tracking variables
let debugIntervalId = null;
let animationFrameId = null;
let resizeHandler = null;

const ADAPTIVE_FALLBACK_ACCENT = "#4facfe";
const ADAPTIVE_TRANSITION_RATE = 0.14;

Expand Down Expand Up @@ -615,7 +620,7 @@ function updateAudioLevel(now) {
}

function renderFrame(now) {
requestAnimationFrame(renderFrame);
animationFrameId = requestAnimationFrame(renderFrame);

if (visualizerState.hidden) {
context.clearRect(0, 0, width, height);
Expand Down Expand Up @@ -871,7 +876,8 @@ function applySettings(nextSettings) {
rebuildCachedPaint();
}

window.addEventListener("resize", resizeCanvas);
resizeHandler = resizeCanvas;
window.addEventListener("resize", resizeHandler);

if (window.audioBridge) {
window.audioBridge.onLevel((payload) => {
Expand Down Expand Up @@ -908,14 +914,50 @@ if (window.visualizerSettings) {
}
}

// Comprehensive cleanup function for all resources
function cleanupResources() {
// Clear debug interval
if (debugIntervalId) {
clearInterval(debugIntervalId);
debugIntervalId = null;
}

// Cancel animation frame
if (animationFrameId) {
cancelAnimationFrame(animationFrameId);
animationFrameId = null;
}

// Remove resize event listener
if (resizeHandler) {
window.removeEventListener("resize", resizeHandler);
resizeHandler = null;
}

console.log("[Renderer] All resources cleaned up");
}

// Clear all resources on window unload
window.addEventListener('beforeunload', cleanupResources);

// Also cleanup on visibility change to hidden (when user switches tabs)
document.addEventListener('visibilitychange', () => {
if (document.hidden) {
// Optional: pause heavy operations when tab is hidden
console.log("[Renderer] Tab hidden, pausing operations");
} else {
console.log("[Renderer] Tab visible, resuming operations");
}
});

createDebugPanel();
refreshBridgeStatus();
if (debugEnabled) {
setInterval(refreshBridgeStatus, 1000);
debugIntervalId = setInterval(refreshBridgeStatus, 1000);
}

resizeCanvas();
requestAnimationFrame(renderFrame);
animationFrameId = requestAnimationFrame(renderFrame);

// --- macOS Glassmorphic Context Menu Integration ---

Expand Down
Loading