Skip to content

feat(theme): deeper theme specific controls#252

Open
Aditya948351 wants to merge 2 commits into
SamXop123:mainfrom
Aditya948351:themetuning
Open

feat(theme): deeper theme specific controls#252
Aditya948351 wants to merge 2 commits into
SamXop123:mainfrom
Aditya948351:themetuning

Conversation

@Aditya948351

Copy link
Copy Markdown
Contributor

Resolves #237

Copilot AI review requested due to automatic review settings June 18, 2026 10:28
@vercel

vercel Bot commented Jun 18, 2026

Copy link
Copy Markdown

@Aditya948351 is attempting to deploy a commit to the Dot_NotSam's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@coderabbitai

coderabbitai Bot commented Jun 18, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 9bc6a316-dee1-4c8a-b6b9-a86977c7fac4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@SamXop123 SamXop123 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! We found two minor bugs that prevent these settings from saving:

  1. settingsStore.js: sanitizeAmbientWave() needs to be updated to return the new fields (blendMode, physicsSmoothing, breathingAmplitude) otherwise they get stripped out on load/save.
  2. settings.js: dispatchThemeUpdate() uses a CSS query selector restricted to #dynamic-theme-settings. We need to expand it so it also collects the selectors inside #dynamic-advanced-theme-settings: const dropdowns = document.querySelectorAll('#dynamic-theme-settings .theme-trigger, #dynamic-advanced-theme-settings .theme-trigger');

Once those are updated, it's ready to merge!

@Aditya948351 Aditya948351 requested a review from SamXop123 June 19, 2026 15:03
@Aditya948351

Copy link
Copy Markdown
Contributor Author

@SamXop123 Requesting your review again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement] Deeper Theme-Specific Controls

3 participants