feat(theme): deeper theme specific controls#252
Conversation
|
@Aditya948351 is attempting to deploy a commit to the Dot_NotSam's projects Team on Vercel. A member of the Team first needs to authorize it. |
b404149 to
f205ab0
Compare
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
f205ab0 to
fca5b89
Compare
SamXop123
left a comment
There was a problem hiding this comment.
Thanks for the PR! We found two minor bugs that prevent these settings from saving:
settingsStore.js: sanitizeAmbientWave() needs to be updated to return the new fields (blendMode, physicsSmoothing, breathingAmplitude) otherwise they get stripped out on load/save.settings.js: dispatchThemeUpdate() uses a CSS query selector restricted to #dynamic-theme-settings. We need to expand it so it also collects the selectors inside#dynamic-advanced-theme-settings:const dropdowns = document.querySelectorAll('#dynamic-theme-settings .theme-trigger, #dynamic-advanced-theme-settings .theme-trigger');
Once those are updated, it's ready to merge!
0c66a25 to
84189ba
Compare
|
@SamXop123 Requesting your review again |
Resolves #237