feat: architect zero-allocation XDR stream parser - #454
Merged
Damola-Sodiq merged 1 commit intoJul 27, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #416
Replaces DOM-based XDR parsing with a zero-allocation, cursor-based byte reader (
xdr_parser.rs). This parser extracts relevant fields (like transaction IDs) sequentially from raw XDR streams without allocating intermediate heap structures for the entire payload.Architectural Changes
Cursor<'a>inxdr_parser.rsto wrap&[u8], providing strictly bounds-checked methods for readingu32,i32,bool,u64, and opaque byte slices.#![no_std]style. It avoidsVecorStringallocations by reading directly from the underlying byte slice and extracting sub-slices for variable-length opaque data.skipmethod to efficiently bypass irrelevant union arms and unneeded fields, ensuring discarded data doesn't consume memory or CPU cycles.Safety & Constraints
remaining()bytes against the requested length, preventing out-of-bounds panics. ReturnsXdrError::UnexpectedEndOfStreamon failure.XdrError::InvalidPaddingfor malformed data.XdrErrorenum instead of unwrapping or panicking.Module Integration
xdr_parsermodule inpackages/contracts/src/lib.rs.