Add unsetSearchDomainForSystemdResolved #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `unsetSearchDomainForSystemdResolved` to revert dns setting before `unsetAddresses` while closing TUN.
This was referenced Feb 11, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds
unsetSearchDomainForSystemdResolved()to thefunc (t *NativeTun) Close()method.Motivation and Context
Previously, the initialization and teardown procedures were asymmetrical, causing DNS configurations to persist in
systemd-resolvedafter the interface was closed.In
configure(tunLink)(Setup):The initialization flow sets up the environment in the following order:
setAddresses->setRoute->setRules->setSearchDomainForSystemdResolvedIn
Close()(Teardown - Before Fix):The cleanup flow missed the corresponding step for systemd-resolved:
unsetAddresses->unsetRoute->unsetRules-> (Missing)In
Close()(Teardown - After Fix):This PR ensures the cleanup logic mirrors the initialization:
unsetSearchDomainForSystemdResolved->unsetAddresses->unsetRoute->unsetRulesChanges
t.unsetSearchDomainForSystemdResolved()infunc (t *NativeTun) Close()to ensure proper DNS cleanup.