Skip to content

feat(divider): align component with fusion DS - #8132

Open
ibutakova wants to merge 1 commit into
masterfrom
FE-7752-align-divider-with-fusion-ds
Open

feat(divider): align component with fusion DS#8132
ibutakova wants to merge 1 commit into
masterfrom
FE-7752-align-divider-with-fusion-ds

Conversation

@ibutakova

Copy link
Copy Markdown
Contributor

Proposed behaviour

Use fusion design tokens for styling Divider

Current behaviour

Styling is not aligned with design tokens

Checklist

  • Commits follow our style guide
  • Related issues linked in commit messages if required
  • Screenshots are included in the PR if useful
  • All themes are supported if required
  • Unit tests added or updated if required
  • Playwright automation tests added or updated if required
  • Storybook added or updated if required
  • Translations added or updated (including creating or amending translation keys table in storybook) if required
  • Typescript d.ts file added or updated if required
  • Related docs have been updated if required

QA

  • Tested in provided StackBlitz sandbox/Storybook
  • Add new Playwright test coverage if required
  • Carbon implementation matches Design System/designs
  • UI Tests GitHub check reviewed if required

Additional context

Testing instructions

nicktitchmarsh
nicktitchmarsh previously approved these changes Aug 13, 2026
@tomdavies73
tomdavies73 self-requested a review August 13, 2026 09:33
Comment thread src/components/divider/divider.test.tsx Outdated
expect(hr).toHaveStyleRule("margin-bottom", "var(--spacing300)");
});

test("should render with the correct background-color for the 'typical' variant", () => {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: I'm not sure additional unit tests are needed here, some changes are valid if we're updating existing tests to use the new tokens.

If we don't need a test for coverage here we can probably avoid adding new ones, chromatic should be doing the majority of our styling checks via snapshots

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Shared colorMap is covered by vertical tests, so I removed three tests not to duplicate. Others look ok.

@ibutakova
ibutakova marked this pull request as ready for review August 14, 2026 10:41
@ibutakova
ibutakova requested review from a team as code owners August 14, 2026 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

6 participants