feat(divider): align component with fusion DS - #8132
Open
ibutakova wants to merge 1 commit into
Open
Conversation
nicktitchmarsh
previously approved these changes
Aug 13, 2026
tomdavies73
self-requested a review
August 13, 2026 09:33
tomdavies73
reviewed
Aug 13, 2026
| expect(hr).toHaveStyleRule("margin-bottom", "var(--spacing300)"); | ||
| }); | ||
|
|
||
| test("should render with the correct background-color for the 'typical' variant", () => { |
Contributor
There was a problem hiding this comment.
suggestion: I'm not sure additional unit tests are needed here, some changes are valid if we're updating existing tests to use the new tokens.
If we don't need a test for coverage here we can probably avoid adding new ones, chromatic should be doing the majority of our styling checks via snapshots
Contributor
Author
There was a problem hiding this comment.
Thanks. Shared colorMap is covered by vertical tests, so I removed three tests not to duplicate. Others look ok.
ibutakova
force-pushed
the
FE-7752-align-divider-with-fusion-ds
branch
from
August 13, 2026 11:57
32381a7 to
2242875
Compare
tomdavies73
approved these changes
Aug 13, 2026
mihai-albu-sage
approved these changes
Aug 13, 2026
edleeks87
approved these changes
Aug 13, 2026
paulrobinson88
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed behaviour
Use fusion design tokens for styling Divider
Current behaviour
Styling is not aligned with design tokens
Checklist
d.tsfile added or updated if requiredQA
Additional context
Testing instructions