feat(tile): align component with Fusion DS - #8129
Draft
mihai-albu-sage wants to merge 1 commit into
Draft
Conversation
mihai-albu-sage
force-pushed
the
FE-7232
branch
2 times, most recently
from
August 13, 2026 08:28
05ae5fe to
920a1dd
Compare
mihai-albu-sage
force-pushed
the
FE-7232
branch
from
August 13, 2026 09:10
920a1dd to
5cefa67
Compare
ibutakova
reviewed
Aug 14, 2026
| if ( | ||
| $hasFooter && | ||
| ($footerVariant === "selected" || $footerVariant === "active") | ||
| ) { |
Contributor
There was a problem hiding this comment.
Should this condition also check outline? At the moment, a selected or active footer appears to create a visible Tile border even when outline isn't enabled. From PR description I understood that Tile border is only when outline is enabled. Or we can skip outline here?
|
|
||
| return ( | ||
| <StyledTileContent | ||
| <Box |
Contributor
There was a problem hiding this comment.
Are we going to preserve existing StyledTyleContent appearance completely? Should we preserve styles between children or first / last child?
| {...marginProps} | ||
| {...tagComponent("tile", rest)} | ||
| > | ||
| <StyledTileWrapper data-role="tile-wrapper" radius={actualRadius}> |
Contributor
There was a problem hiding this comment.
Is there a reason we apply width / height just to inner StyledTile? For example, passing 50% width can leave full-width StyledTileWrapper with half-width StyledTile.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed behaviour
The following changes have been made:
The
TileHeadercomponent has been deprecated. The styled component has been removed, andTileHeaderis now based on theBoxcomponent. To ensure backwards compatibility untilTileHeaderis fully removed, the styles previously defined in the styled component have been moved to props on the exportedBoxcomponent.The
TileContentcomponent has been deprecated. The styled component has been removed, andTileContentis now based on theBoxcomponent. To ensure backwards compatibility untilTileContentis fully removed, the styles previously defined in the styled component have been moved to props on the exportedBoxcomponent.The
TileFootervariants have been updated, with the existing variants deprecated in favor of the new ones. When aTilehasoutlineset totrue, and therefore has a visible border, aTileFooterwith theselectedoractivevariant will also determine the border color of the entireTile.The following props have been marked as deprecated:
orientation: TheTilewill now be horizontally oriented by default.borderWidth: Deprecated, as custom border widths are no longer supported.borderVariant: Deprecated, as custom border variants are no longer supported. The border color can instead be controlled using theTilevariant together with theoutlineprop.roundness: Deprecated in favor of the newradiusprop. Existing roundness values have been mapped to their corresponding radius values to maintain backwards compatibility.highlightVariant: Deprecated in favor of the newstatusKeylineprop. Existing highlightVariant values have been mapped to their corresponding statusKeyline values to maintain backwards compatibility.Current behaviour
Checklist
d.tsfile added or updated if requiredQA
Additional context
Testing instructions