feat(dialog): add dialog header component - FE-7750 - #8128
Draft
DipperTheDan wants to merge 1 commit into
Draft
Conversation
DipperTheDan
force-pushed
the
dialog-heading-variants-spike
branch
from
August 12, 2026 14:38
79da4a3 to
abc5558
Compare
ibutakova
self-requested a review
August 13, 2026 10:51
ibutakova
reviewed
Aug 13, 2026
| @@ -264,7 +264,7 @@ const StyledDialogTitle = styled.div<StyledDialogTitleProps>` | |||
|
|
|||
| [data-element="dialog-title-help-wrapper"] { | |||
Contributor
There was a problem hiding this comment.
Markup using dialog-title-help-wrapper is removed, so this selector looks dead, isn't it?
ibutakova
reviewed
Aug 13, 2026
| <Icon | ||
| type={iconType} | ||
| color={color} | ||
| fontSize="medium" |
Contributor
There was a problem hiding this comment.
Check if fontSize is deprecated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed behaviour
Refactor the HOC for heading variants.
Current behaviour
Currently we have a HOC for generating heading variants but this is overkill for what we need.
Checklist
d.tsfile added or updated if requiredQA
Additional context
N/A
Testing instructions
There should be no visual or functional regressions with the heading variants of Dialog.