Conversation
Ensures focused tab is fully visible when using keyboard navigation. Also ensures that left scroll button is rendered when using keyboard navigation. fix #8093
ibutakova
reviewed
Aug 6, 2026
| // scrollIntoView is not implemented in jsdom but hasn't been marked as such | ||
| Element.prototype.scrollIntoView = jest.fn(); | ||
| }); | ||
|
|
Contributor
There was a problem hiding this comment.
Are you sure we need this mock in legacy? i see no other changes in legacy, or scrollIntoView call
DipperTheDan
self-requested a review
August 6, 2026 11:46
DipperTheDan
reviewed
Aug 6, 2026
DipperTheDan
left a comment
DipperTheDan
left a comment
Contributor
There was a problem hiding this comment.
I'm happy to approve once @ibutakova question has been answered.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #8093, #7570
Proposed behaviour
When horizontal scrolling is present and using keyboard navigation:
Tabis fully visible.Current behaviour
When horizontal scrolling is present and using keyboard navigation:
Tabis obscured.Checklist
d.tsfile added or updated if requiredQA
Additional context
Testing instructions