fix(dialog): honour contentPadding on fullscreen dialogs above 600px - #8112
Draft
tamas-sage wants to merge 1 commit into
Draft
fix(dialog): honour contentPadding on fullscreen dialogs above 600px#8112tamas-sage wants to merge 1 commit into
tamas-sage wants to merge 1 commit into
Conversation
DipperTheDan
reviewed
Aug 4, 2026
Comment on lines
+84
to
+99
| const contentPaddingKeys = [ | ||
| "p", | ||
| "padding", | ||
| "px", | ||
| "paddingX", | ||
| "py", | ||
| "paddingY", | ||
| "pt", | ||
| "paddingTop", | ||
| "pr", | ||
| "paddingRight", | ||
| "pb", | ||
| "paddingBottom", | ||
| "pl", | ||
| "paddingLeft", | ||
| ]; |
Contributor
There was a problem hiding this comment.
suggestion(non-blocking): We have a config file in the __next__ Dialog. This could possibly live in there but I'm not precious about this. Happy for you to leave it for second reviewer to decide if this is a good idea or not.
Contributor
|
Just a reminder before you come to merge this, remember to include the original Github issue (#8103) in the commit message please. It's just so that the issue is automatically closed when this is merged 👍🏻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed behaviour
The default padding is now skipped when a contentPadding prop is present, so the consumer's value (e.g. { p: 0 }) is honoured at all widths. Dialogs without contentPadding keep the existing default.
Current behaviour
On
size="fullscreen"dialogs, contentPadding is ignored above 600px. Fullscreen dialogs always apply a responsive default side padding regardless of whether contentPadding was set,so contentPadding={{ p: 0 }}only works below 600px.Checklist
d.tsfile added or updated if requiredQA
Additional context
Testing instructions