feat(popover-container): align component with fusion designs - #8100
Draft
edleeks87 wants to merge 1 commit into
Draft
feat(popover-container): align component with fusion designs#8100edleeks87 wants to merge 1 commit into
edleeks87 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed behaviour
Aligns with new PopoverContainer fusion designs
Uses
nextButtonDeprecates
centeralignmentDeprecates border radius prop
Adds translation key for default
openButton.text()Can be overridden by passing children directly as and when needed to open button render prop
Current behaviour
Not aligned with fusion
default open button is icon only and uses deprecated Button and IconButton
Checklist
d.tsfile added or updated if requiredQA
Additional context
Testing instructions